Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

256 options escaping #257

Closed
wants to merge 6 commits into from
Closed

256 options escaping #257

wants to merge 6 commits into from

Conversation

Mopok
Copy link
Contributor

@Mopok Mopok commented Aug 24, 2017

#256

Fixes

  • Options now work when there is 2+ options on a product
  • The URL now handles 2+ options
  • Removed some unnecessary twig to angular param passing (fixed multiple escaping issues)
  • Fixes error which is originally showed in Product Option Issue with Colon in Name/Value #256. However another error still shows up, look below. This error does not break the theme, but I believe it slows loading down a bit. It only occurs when /,' or " is in an option value.
  • Added error msg for missing state during checkout

Still issues with / in option value. The option will work fine, however I get a syntax error in the minified vendor code:
screen shot 2017-08-24 at 12 52 58 pm

@Mopok Mopok requested a review from tomcornall August 24, 2017 20:28
@dhalarewich
Copy link
Contributor

@robotpony this needs review

@robotpony
Copy link
Member

Closing (should be in other patches).

@robotpony robotpony closed this Nov 1, 2017
@robotpony robotpony deleted the 256-options-escaping branch November 1, 2017 19:13
@rudy-sasquatchstudio rudy-sasquatchstudio restored the 256-options-escaping branch November 7, 2017 22:12
@robotpony robotpony deleted the 256-options-escaping branch November 14, 2017 20:16
@rudy-sasquatchstudio rudy-sasquatchstudio restored the 256-options-escaping branch November 16, 2017 00:10
@robotpony robotpony deleted the 256-options-escaping branch November 21, 2017 23:38
@rudy-sasquatchstudio rudy-sasquatchstudio restored the 256-options-escaping branch November 22, 2017 00:01
@robotpony robotpony deleted the 256-options-escaping branch December 19, 2017 18:46
@rudy-sasquatchstudio rudy-sasquatchstudio restored the 256-options-escaping branch February 2, 2018 19:28
@robotpony robotpony deleted the 256-options-escaping branch April 13, 2018 18:02
@rudy-sasquatchstudio rudy-sasquatchstudio restored the 256-options-escaping branch April 16, 2018 21:23
@robotpony robotpony deleted the 256-options-escaping branch April 25, 2018 21:31
@rudy-sasquatchstudio rudy-sasquatchstudio restored the 256-options-escaping branch April 25, 2018 21:58
@robotpony robotpony deleted the 256-options-escaping branch November 14, 2018 20:26
@rudy-sasquatchstudio rudy-sasquatchstudio restored the 256-options-escaping branch November 15, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants