-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support azure cloud #150
base: develop
Are you sure you want to change the base?
Conversation
ian-lemon
commented
Aug 8, 2023
- cosmos db 연결
- save, read, update, delete 구현
src/cores/cosmos/cosmos-service.ts
Outdated
* `cosmos-service.ts` | ||
* - common service for cosmos | ||
* | ||
* @author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 항목 제대로 넣어줘유
src/cores/cosmos/cosmos-service.ts
Outdated
* @author | ||
* @date | ||
* | ||
* @copyright (C) 2019 LemonCloud Co Ltd. - All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 최초 작업 날짜로 넣어줘유
@@ -23,206 +23,230 @@ interface AccountModel extends StorageModel { | |||
describe('StorageService', () => { | |||
const PROFILE = loadProfile(); // use `env/<ENV>.yml` | |||
|
|||
//! dummy storage service. | |||
it('should pass dummy storage-service', async done => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정되지 않는 부분에서 수정이 된걸봐서는 editor의 indent 설정이 이상한듯. 맞춰줘유.
src/environ.ts
Outdated
@@ -74,7 +75,7 @@ export const loadEnviron = (process: any, options?: Options) => { | |||
//! join array with ', '. | |||
$O[key] = val.join(', '); | |||
} else if ($det[key] === undefined) { | |||
//! override only if undefined. | |||
//! ov998rride only if undefined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
의도치않은 코드 변경인듯
@@ -97,6 +98,20 @@ const credentials = (profile: string): string => { | |||
if (!profile) return ''; | |||
const credentials = new AWS.SharedIniFileCredentials({ profile }); | |||
AWS.config.credentials = credentials; | |||
|
|||
const accessKeyId = process.env.AWS_ACCESS_KEY_ID; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 environ먹게 한듯한데, 이렇게 하믄 안될듯.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.env file을 사용하지 말고 다른 방법으로 자격증명을 로드하면 되는지, 아니면 environ.ts 밖에서 구현해야하는지 문의 드립니다.
최초 테스트 버전입니다. 리팩토링 필요성
문제점
|
리팩토링 후 문제점도 해결하였습니다. |
space : 4 변경으로 인한 수정표시. let key_list: string[] = [];
let value_list: (string | number)[] = [];
if (item !== null && item !== undefined) {
for (const value of Object.values(item)) {
if (typeof value === 'string' || typeof value === 'number') {
value_list.push(value);
}
}
key_list = Object.keys(item)
} |
|
Query builder에 기존 Condition을 넣어주었습니다. |
|