This repository has been archived by the owner on Feb 20, 2024. It is now read-only.
fix(FF): it works #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mderrier
commented
Dec 8, 2020
| "rollup-plugin-postcss": "^3.1.8", | ||
| "rollup-plugin-terser": "^7.0.2", | ||
| "rollup-plugin-typescript2": "^0.29.0", | ||
| "ts-jest": "^26.4.4", | ||
| "typescript": "^4.0.5" | ||
| }, | ||
| "dependencies": { | ||
| "@webcomponents/webcomponentsjs": "2.5.0" | ||
| "@webcomponents/webcomponentsjs": "2.2.10" |
There was a problem hiding this comment.
FF 54 doesn't work with webcomponents polyfill > 2.2
mderrier
commented
Dec 8, 2020
| @@ -172,6 +173,9 @@ const ROLLUP = [ | |||
| moduleDirectory: 'submodules/math-json/src', | |||
| }, | |||
| }), | |||
| polyfill([ | |||
| '@webcomponents/webcomponentsjs/webcomponents-bundle.js', | |||
There was a problem hiding this comment.
inject polyfill via rollup
polyfill injected in code doesn't work with multi-instance
mderrier
commented
Dec 8, 2020
src/public/mathfield-element.ts
Outdated
| constructor(options?: Partial<MathfieldOptions>) { | ||
| super(); | ||
|
|
||
| if ((window as any).ShadyCSS) { | ||
| (window as any).ShadyCSS.prepareTemplate(MATHFIELD_TEMPLATE, 'host'); |
mderrier
commented
Dec 8, 2020
| @@ -383,18 +388,18 @@ export class MathfieldElement extends HTMLElement implements Mathfield { | |||
| ); | |||
|
|
|||
| // Inline options (as a JSON structure in the markup) | |||
| try { | |||
| const json = slot | |||
| .assignedElements() | |||
mderrier
commented
Dec 8, 2020
|
|
||
| this.#mathfield = new MathfieldPrivate( | ||
| this.shadowRoot.querySelector(':host > div'), |
There was a problem hiding this comment.
":host" selector doesn't work on older browser
mpech
approved these changes
Dec 9, 2020
arncet
approved these changes
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use rollup to inject polyfill (FF < 63 support + IE 11)
remove sound (chronoquiz crash)