bad code practice #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lei Wen <[email protected]>
|
Preparing review... |
1 similar comment
|
Preparing review... |
PR Analysis
PR Feedback
|
wenlei03
commented
Oct 17, 2023
| @@ -35,6 +35,8 @@ def has_cutlass(): | |||
| """Returns true if the CUTLASS custom codegen is available""" | |||
| return tvm.get_global_func("relay.ext.cutlass.create_c_source_module", True) is not None | |||
|
|
|||
| def ddd(): | |||
There was a problem hiding this comment.
Remove the unused function 'ddd' [important]
| @@ -35,6 +35,8 @@ def has_cutlass(): | |||
There was a problem hiding this comment.
Add docstrings and comments to explain the purpose and usage of the code [medium]
| @@ -35,6 +35,8 @@ def has_cutlass(): | |||
| """Returns true if the CUTLASS custom codegen is available""" | |||
| return tvm.get_global_func("relay.ext.cutlass.create_c_source_module", True) is not None | |||
|
|
|||
| def ddd(): | |||
| print("testing") | |||
|
|
|||
| def _get_cutlass_path(): | |||
There was a problem hiding this comment.
Add more tests to ensure that the code is working correctly and to prevent future regressions [medium]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.