Pangene Revisions #404
Open
Pangene Revisions #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This component implements the same interface as the loading component but can be used inline, e.g. next to the download button in a form. In addition to being an inline element, the distinguishing features of the inline loading component is that its loading spinner doesn't cover/disable other parts of the UI and result states are conveyed as icons rather than an alert element, with messages being shown in a tooltip on the icons.
Specifically, the downloading element should be an instance of the inline loading component. If present, it will be utilized to convey the status of a download request submitted by the search form.
This element is utilized by the underlying search mixins to convey the status of download requests initialized by the component's lookup form.
These are required by the inline loading component utilized by the pangene lookup component for its download button.
The search and paginated search mixins have been combined into one again. This is because their code was very redundant and hard to extend and debug. Also, no components were actually using the non-paginated search mixin.
This is controlled via a new queryStringReflection property, which is set to true by default.
This is mostly because the value of the genes form field may exceed the length limit of the web browser URL.
|
hmm, looks like the fix did not actually solve #399 or else has transformed it into something a little different (my bad for not supplying more detail in that issue, going to update it now with some more info about what I'm seeing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes: