[data views] Data views / runtime field creation flaky test fix (elas…

…tic#177315) ## Summary Fix runtime field creation flaky test. Just a pair of minor test improvements. Passed a 200x run through the flaky test runner. Closes: elastic#173558 and elastic#178733
leemthompo · Mar 18, 2024 · e0adf1d · e0adf1d
1 parent 059e4a5
commit e0adf1d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -857,6 +857,9 @@ export class SettingsPageObject extends FtrService {
   async clickAddField() {
     this.log.debug('click Add Field');
     await this.testSubjects.click('addField');
+    await this.retry.try(async () => {
+      await this.testSubjects.existOrFail('flyoutTitle');
+    });
   }
 
   async clickSaveField() {
@@ -872,8 +875,7 @@ export class SettingsPageObject extends FtrService {
 
   async setFieldType(type: string) {
     this.log.debug('set type = ' + type);
-    await this.testSubjects.setValue('typeField', type);
-    await this.browser.pressKeys(this.browser.keys.ENTER);
+    await this.comboBox.set('typeField', type);
   }
 
   async setFieldTypeComposite() {

diff --git a/...ck/test_serverless/functional/test_suites/common/management/data_views/_runtime_fields.ts b/...ck/test_serverless/functional/test_suites/common/management/data_views/_runtime_fields.ts
@@ -16,8 +16,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const PageObjects = getPageObjects(['settings', 'common']);
   const testSubjects = getService('testSubjects');
 
-  // Failing: See https://github.com/elastic/kibana/issues/173558
-  describe.skip('runtime fields', function () {
+  describe('runtime fields', function () {
     before(async function () {
       await browser.setWindowSize(1200, 800);
       await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
@@ -64,6 +63,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           await testSubjects.existOrFail('flyoutTitle');
         });
         await PageObjects.settings.setFieldType('Long');
+        await new Promise((r) => setTimeout(r, 500));
         await PageObjects.settings.setFieldScriptWithoutToggle('emit(6);');
         await PageObjects.settings.toggleRow('formatRow');
         await PageObjects.settings.setFieldFormat('bytes');

diff --git a/...rverless/functional/test_suites/common/management/data_views/_runtime_fields_composite.ts b/...rverless/functional/test_suites/common/management/data_views/_runtime_fields_composite.ts
@@ -17,8 +17,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
 
   describe('runtime fields', function () {
-    // https://github.com/elastic/kibana/issues/178733
-    this.tags('failsOnMKI');
     before(async function () {
       await browser.setWindowSize(1200, 800);
       await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');