Skip to content

Commit

Permalink
fix: [Stateful: Connectors:New connector page]Copy buttons are missin…
Browse files Browse the repository at this point in the history
…g their name during announcement (elastic#198003)

Closes: elastic#197580

## Summary

All buttons should not only be clear, understandable when the user sees
them, but also for the users using assistive technology.

## What was changed?: 

1.  `aria-label` attributes were added for mentioned buttons 

## Screen:

<img width="937" alt="image"
src="https://github.com/user-attachments/assets/de861cfe-e851-4f29-8112-a7258a31ad8c">
  • Loading branch information
alexwizp authored Nov 4, 2024
1 parent 36a366a commit 105ee06
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ export const GeneratedConfigFields: React.FC<GeneratedConfigFieldsProps> = ({
data-test-subj="enterpriseSearchConnectorDeploymentButton"
iconType="copyClipboard"
onClick={copy}
aria-label={i18n.translate(
'xpack.enterpriseSearch.connectorDeployment.copyConnectorId',
{ defaultMessage: 'Copy connector ID' }
)}
/>
)}
</EuiCopy>
Expand Down Expand Up @@ -237,6 +241,10 @@ export const GeneratedConfigFields: React.FC<GeneratedConfigFieldsProps> = ({
isLoading={isGenerateLoading}
onClick={refreshButtonClick}
disabled={!connector.index_name}
aria-label={i18n.translate(
'xpack.enterpriseSearch.connectorDeployment.refreshAPIKey',
{ defaultMessage: 'Refresh an Elasticsearch API key' }
)}
/>
</EuiFlexItem>
)}
Expand All @@ -246,6 +254,10 @@ export const GeneratedConfigFields: React.FC<GeneratedConfigFieldsProps> = ({
data-test-subj="enterpriseSearchConnectorDeploymentButton"
iconType="copyClipboard"
onClick={copy}
aria-label={i18n.translate(
'xpack.enterpriseSearch.connectorDeployment.copyIndexName',
{ defaultMessage: 'Copy index name' }
)}
/>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down

0 comments on commit 105ee06

Please sign in to comment.