Skip to content

Commit

Permalink
Rename search response metric attribute (elastic#110842)
Browse files Browse the repository at this point in the history
This change renames the search response metric attribute status to response_status. This is more 
descriptive for an attribute that falls under the global labels namespace.

This also fixes a typo with succes to success.
  • Loading branch information
jdconrad authored Jul 12, 2024
1 parent 7593db8 commit 13c3211
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
public class SearchResponseMetrics {

public enum ResponseCountTotalStatus {
SUCCESS("succes"),
SUCCESS("success"),
PARTIAL_FAILURE("partial_failure"),
FAILURE("failure");

Expand All @@ -35,7 +35,7 @@ public String getDisplayName() {
}
}

public static final String RESPONSE_COUNT_TOTAL_STATUS_ATTRIBUTE_NAME = "status";
public static final String RESPONSE_COUNT_TOTAL_STATUS_ATTRIBUTE_NAME = "response_status";

public static final String TOOK_DURATION_TOTAL_HISTOGRAM_NAME = "es.search_response.took_durations.histogram";
public static final String RESPONSE_COUNT_TOTAL_COUNTER_NAME = "es.search_response.response_count.total";
Expand Down

0 comments on commit 13c3211

Please sign in to comment.