-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/#8-write-data-type-between-ledgers #53
feat/#8-write-data-type-between-ledgers #53
Conversation
danielvo11
commented
Sep 9, 2020
•
edited
Loading
edited
- remove uint64_t type
- add int, bool, double and address type
Data type | EOS | ICON |
---|---|---|
boolean | bool | bool |
number | double | int |
uint64 | uint64_t | int |
uint32 | uint32_t | int |
uint16 | uint32_t | int |
string | string | string |
account | name | Address |
Should change address to account in abstract class for easy understand |
It looks great thank @danielalvess. Since this MR is going to make a huge conflict with #44, I prefer to review and merge #44 first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls resolve conflic
I don't think we have to introduce new names for the data type. #53 (comment). Since data type in EOS can be considered as a superset of data type in ICON, we can use names of data types in EOS in our yaml file. For example:
It is ok with |
aeb1f35
to
5465698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other things look good to me.
packages/bridge/smart-contract-templates/icon/icon_hello/icon_hello.py.hbs
Show resolved
Hide resolved
Agreed that the default value of |
5465698
to
d853413
Compare
d853413
to
e8741ec
Compare