Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/#8-write-data-type-between-ledgers #53

Merged

Conversation

danielvo11
Copy link
Contributor

@danielvo11 danielvo11 commented Sep 9, 2020

  • remove uint64_t type
  • add int, bool, double and address type
Data type EOS ICON
boolean bool bool
number double int
uint64 uint64_t int
uint32 uint32_t int
uint16 uint32_t int
string string string
account name Address

@quocle108
Copy link
Contributor

Should change address to account in abstract class for easy understand

@manh-vv
Copy link
Member

manh-vv commented Sep 9, 2020

It looks great thank @danielalvess. Since this MR is going to make a huge conflict with #44, I prefer to review and merge #44 first.

Copy link
Contributor

@quocle108 quocle108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls resolve conflic

@manh-vv
Copy link
Member

manh-vv commented Sep 17, 2020

@danielalvess

I don't think we have to introduce new names for the data type. #53 (comment). Since data type in EOS can be considered as a superset of data type in ICON, we can use names of data types in EOS in our yaml file. For example:

Data type EOS ICON
bool bool bool
string string string
number uint64_t int
uint64_t uint64_t int
uint32_t uint32_t int
uint16_t uint16_t int
account name Address

It is ok with number but please keep the default of number in EOS to be uint_64.

@danielvo11 danielvo11 force-pushed the feat/#8-write-data-type-between-ledgers branch 2 times, most recently from aeb1f35 to 5465698 Compare September 22, 2020 09:02
Copy link
Member

@manh-vv manh-vv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other things look good to me.

@manh-vv
Copy link
Member

manh-vv commented Sep 22, 2020

Agreed that the default value of number is double.

@danielvo11 danielvo11 force-pushed the feat/#8-write-data-type-between-ledgers branch from 5465698 to d853413 Compare September 22, 2020 09:47
@manh-vv manh-vv merged commit be4eb7c into lecle:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants