Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing unit test by missing svg #224

Merged

Conversation

ScottVerbeek
Copy link
Contributor

@ScottVerbeek ScottVerbeek commented Oct 4, 2024

This will add the disabled icon to the pix library of the module, resolving the previously failing unit test

$ vendor/bin/phpunit --filter="test_svg_fallback"
Moodle 4.3.4+ (Build: 20240530), 11a2641a137bf21552868a24d6439011e027ebe3
Php: 8.1.28, pgsql: 16.0 (Debian 16.0-1.pgdg120+1), OS: Linux 6.4.12-060412-generic x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

.                                                                   1 / 1 (100%)

Time: 00:05.430, Memory: 342.00 MB

OK (1 test, 508 assertions)
The output of failing unit test before this change
Moodle 4.3.4+ (Build: 20240530), 11a2641a137bf21552868a24d6439011e027ebe3
Php: 8.1.28, pgsql: 16.0 (Debian 16.0-1.pgdg120+1), OS: Linux 6.4.12-060412-generic x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

F                                                                   1 / 1 (100%)

Time: 00:05.554, Memory: 340.00 MB

There was 1 failure:

1) core\output\icon_system_fontawesome_test::test_svg_fallback
No SVG equivalent found for 'tool_lifecycle:t/disable'
Failed asserting that false is true.

/var/www/moodle-43/lib/tests/output/icon_system_fontawesome_test.php:56
/var/www/moodle-43/lib/phpunit/classes/advanced_testcase.php:81

FAILURES!
Tests: 1, Assertions: 495, Failures: 1.

@justusdieckmann justusdieckmann merged commit e8e3828 into learnweb:master Oct 13, 2024
23 checks passed
@justusdieckmann
Copy link
Member

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants