Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/completiontracking #299

Merged
merged 33 commits into from
Aug 26, 2024
Merged

Feature/completiontracking #299

merged 33 commits into from
Aug 26, 2024

Conversation

irinahpe
Copy link
Contributor

Adds custom completion rules to the ratingallocate activity.
Options are completion on having voted and completion on having been allocated.

irinahpe added 26 commits July 30, 2024 11:42
@irinahpe irinahpe force-pushed the feature/completiontracking branch from 4d90aa8 to 48e2bf4 Compare July 30, 2024 09:59
Copy link
Contributor

@Laur0r Laur0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something does not work as intended with the vote completion. As soon as the rating period starts, this is set to true for all users without having submitted a rating.

lib.php Outdated
@@ -70,6 +70,10 @@ function ratingallocate_supports($feature) {
return true;
case FEATURE_COMPLETION_TRACKS_VIEWS:
return true;
case FEATURE_COMPLETION_HAS_RULES:
return true;
case FEATURE_COMPLETION_HAS_RULES:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one of these duplicates can be removed.

Copy link
Contributor

@Laur0r Laur0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Laur0r Laur0r merged commit 89ad999 into master Aug 26, 2024
50 checks passed
@Laur0r Laur0r deleted the feature/completiontracking branch August 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants