Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/namespace discrepancy #296

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Fix/namespace discrepancy #296

merged 3 commits into from
Apr 18, 2024

Conversation

irinahpe
Copy link
Contributor

@irinahpe irinahpe commented Mar 6, 2024

Add consistent namespaces with mod_ratingallocate on level1.

Closes #292

@FelixDiLenarda
Copy link

The incorrect namespace designations lead to the failure of the ad_hoc task with the following output:

Execute adhoc task: mod_ratingallocate\task\distribute_unallocated_task
Adhoc task id: 90667432
Adhoc task custom data: {"courseid":"38278","cmid":"1786341","distributionalgorithm":"distribute_unallocated_equally"}
... started 12:13:03. Current memory use 42.6 MB.
Debugging increased temporarily due to faildelay of 7680
... used 1 dbqueries
... used 0.00084400177001953 seconds
Adhoc task failed: mod_ratingallocate\task\distribute_unallocated_task,Undefined constant "mod_ratingallocate\task\ACTION_DISTRIBUTE_UNALLOCATED_EQUALLY"
Backtrace:
* line 508 of /lib/classes/cron.php: call to mod_ratingallocate\task\distribute_unallocated_task->execute()
* line 302 of /lib/classes/cron.php: call to core\cron::run_inner_adhoc_task()
* line 128 of /lib/classes/cron.php: call to core\cron::run_adhoc_tasks()
* line 186 of /admin/cli/cron.php: call to core\cron::run_main_process()

This PR fixes the Issue.
The integration of the pull request is therefore eagerly anticipated. :)

@PhMemmel
Copy link
Contributor

I think the issue already should be have been fixed by #294, however correct namespaces are always a good idea :)

@FelixDiLenarda
Copy link

Even better :) Apologies for the fuss.

Copy link
Contributor

@Laur0r Laur0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the namespaces!

@Laur0r Laur0r merged commit 188c17f into master Apr 18, 2024
46 checks passed
@Laur0r Laur0r deleted the fix/namespace_discrepancy branch April 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible namespacing issue
4 participants