Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve ratingallocate navigation #277

Merged
merged 9 commits into from
May 7, 2024

Conversation

irinahpe
Copy link
Contributor

@irinahpe irinahpe commented Aug 4, 2023

This feature adds tabs for navigating to Choices and Statistics to the navigation bar of the activity.
The use of the current Behat features is not supported by Moodle 3.9 and 3.11

@Laur0r
Copy link
Contributor

Laur0r commented Aug 7, 2023

The new navigation looks great! However, the function settings_navigation::get_page() does not exist for Moodle 3.9/3.11 and therefore leads to errors for these versions. There should be some workaround until they are no longer officially supported.

@Laur0r
Copy link
Contributor

Laur0r commented Oct 6, 2023

There is an error "undefined constant ACTION_SHOW_CHOICES" when going to the permission settings.

@Laur0r
Copy link
Contributor

Laur0r commented Dec 22, 2023

As the support for Moodle 3.9 and 3.11 has now officially expired, please remove them from the workflow. Then the tests will run through.

Copy link
Contributor

@Laur0r Laur0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thanks!

@Laur0r Laur0r merged commit 83ef413 into master May 7, 2024
38 checks passed
@Laur0r Laur0r deleted the feature/improve_ratingallocate_navigation branch May 7, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants