Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Update blockly-editor.effects.ts #103

Closed
wants to merge 5 commits into from
Closed

Update blockly-editor.effects.ts #103

wants to merge 5 commits into from

Conversation

JeftadeGraaf
Copy link
Contributor

icm 10-standaard-google-blocks-uit-blocks-repo-verwijderen.

@koen1711 koen1711 self-requested a review January 18, 2024 07:07
@JeftadeGraaf JeftadeGraaf requested a review from a team as a code owner January 21, 2024 06:58
Copy link
Member

@koen1711 koen1711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you still have duplicates because in blocks you also define these blocks

@koen1711 koen1711 added the enhancement New feature or request label Jan 27, 2024
Added the import for the isSimpleReporter() function.
@JeftadeGraaf
Copy link
Contributor Author

I have changed some things around, now it is working without bugs. I could not find a fix for the styling issue.

The style component in the definition of blocks is not using the same category's as we are using. For example, logic_operation has style logic_blocks while most other blocks in the category numbers are using the style math_blocks. You could maybe fix this by changing the style before the blocks are defined. I could not find a fix, maybe some of you can?

@JeftadeGraaf
Copy link
Contributor Author

For now I have just overwritten some blocks to have the situation_blocks style. They are still hardcoded instead of using the blockly library. When you are ready to accept this PR, dont forget to also update the npm package with it. You can change the merge conflicts in package.json and yarn.lock

@JeftadeGraaf JeftadeGraaf self-assigned this Feb 12, 2024
@koen1711
Copy link
Member

@JeftadeGraaf You need to fis merge conflicts yourself.

@rmoesbergen
Copy link
Member

already done in a different PR.

@koen1711 koen1711 deleted the defaultBlocks branch April 22, 2024 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants