Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to load the old XML and new JSON format in blockly workspaces #59

Merged
merged 4 commits into from
May 14, 2024

Conversation

pajotg
Copy link
Contributor

@pajotg pajotg commented May 10, 2024

This adds 2 tests that are very similar that check if loading a workspace from a save file is working correctly.

I am not sure about the way i've done the createOnWritePromise function in utils.ts:53, but I think it can be done better.

@pajotg pajotg requested a review from a team as a code owner May 10, 2024 14:07
@pajotg pajotg requested a review from rmoesbergen May 10, 2024 14:07
@pajotg pajotg merged commit 7b8a879 into main May 14, 2024
1 check passed
@pajotg pajotg deleted the playwright_workspace_save_and_load branch May 14, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants