Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require a filename for save as dialog #57

Merged
merged 8 commits into from
May 11, 2024
Merged

Conversation

rmoesbergen
Copy link
Member

No description provided.

@rmoesbergen rmoesbergen requested a review from a team as a code owner May 9, 2024 17:03
@rmoesbergen rmoesbergen requested a review from koen1711 May 9, 2024 17:03
@rmoesbergen rmoesbergen linked an issue May 9, 2024 that may be closed by this pull request
Copy link
Member

@sverben sverben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add the required prop on the input element instead of checking in the save method, this will in most browsers also trigger a tooltip indicating you haven't filled out the field, providing additional user feedback

src/lib/components/core/popups/popups/Prompt.svelte Outdated Show resolved Hide resolved
@rmoesbergen
Copy link
Member Author

you can add the required prop on the input element instead of checking in the save method, this will in most browsers also trigger a tooltip indicating you haven't filled out the field, providing additional user feedback

done, still need the return in save() to prevent the dialog from closing when the form is not valid

@rmoesbergen rmoesbergen requested a review from sverben May 10, 2024 07:42
@koen1711
Copy link
Member

Leaving review to @sverben

@rmoesbergen rmoesbergen merged commit a2f6a55 into main May 11, 2024
1 check passed
@rmoesbergen rmoesbergen deleted the save-without-name branch May 11, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Saving without a name
3 participants