-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: require a filename for save as dialog #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add the required prop on the input element instead of checking in the save method, this will in most browsers also trigger a tooltip indicating you haven't filled out the field, providing additional user feedback
a178c73
to
2c009d7
Compare
done, still need the return in save() to prevent the dialog from closing when the form is not valid |
Leaving review to @sverben |
No description provided.