-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show browser not supported popup at startup #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please first detect if we can use a fallback driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please copy the styling from the warning dialog, also differentiate between the recommended (primary) and secondary buttons with styling, in this case primary would probably be "I understand", and secondary "don't show again"
…ed styling for the popup
The check is not correct this way, since firefox does support WebUSB, but we only support uploads to FTDI devices with WebUSB. So if you try to upload to a CH340 based device using firefox, you would not get the dialog, but the upload would fail. I don't think we can reliably check for this at startup, since you have to know which device is connected. I guess the check needs to move to after where the connection is made. |
@sverben @rmoesbergen I'm reviewing this and I see nothing wrong with this PR, all your concerns seem to be adressed? Can you confirm? |
This PR adds a popup at startup when you are using a browser that doesn't support web-serial like firefox