Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51 Searchbar #80

Merged
merged 5 commits into from
Sep 24, 2024
Merged

51 Searchbar #80

merged 5 commits into from
Sep 24, 2024

Conversation

mwarman
Copy link
Member

@mwarman mwarman commented Sep 24, 2024

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

List the changes included in this pull request.

  • Issue: Search bar #51
  • Create a Searchbar component that wraps IonSearchbar
  • Update Header to accept multiple additional IonToolbar components
  • Add search to user list page

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings

🧪 Steps to Test

Describe the process to test the changes in this pull request.

  1. On the user list page, use the search toolbar to filter the list.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • ...

@mwarman mwarman added the enhancement New feature or request label Sep 24, 2024
@mwarman mwarman self-assigned this Sep 24, 2024
@mwarman mwarman linked an issue Sep 24, 2024 that may be closed by this pull request
@mwarman mwarman merged commit 2a14184 into main Sep 24, 2024
4 checks passed
@mwarman mwarman deleted the 51-search-bar branch September 24, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar
1 participant