Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lake: eager logging when materializing deps #6225

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Nov 26, 2024

This PR makes lake build also eagerly print package materialization log lines. Previously, only a lake update performed eager logging.

@tydeu tydeu added the changelog-lake Lake label Nov 26, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 26, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 26, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@tydeu tydeu marked this pull request as ready for review November 26, 2024 19:53
@tydeu tydeu enabled auto-merge November 26, 2024 22:11
@tydeu tydeu added this pull request to the merge queue Nov 26, 2024
Merged via the queue into leanprover:master with commit 51015bf Nov 26, 2024
24 checks passed
@tydeu tydeu deleted the lake/materializeDeps-loggerIO branch November 26, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants