Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove partial keyword and runtime bounds checks from Array.binSearch #6193

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Nov 24, 2024

This PR completes the TODO in Init.Data.Array.BinSearch, removing the partial keyword and converting runtime bounds checks to compile time bounds checks.

@kim-em kim-em changed the title chore: remove partial and runtime bounds checks from Array.binSearch feat: remove partial keyword and runtime bounds checks from Array.binSearch Nov 24, 2024
@kim-em kim-em added the changelog-library Library label Nov 24, 2024
@kim-em
Copy link
Collaborator Author

kim-em commented Nov 24, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit bcc22fd.
There were significant changes against commit bf13b24:

  Benchmark     Metric          Change
  ==============================================
+ simp_arith1   branch-misses    -3.2% (-24.3 σ)
- stdlib        type checking     3.1%  (11.2 σ)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 24, 2024 05:52 Inactive
@kim-em
Copy link
Collaborator Author

kim-em commented Nov 24, 2024

Seems like nothing of significance in !bench.

Once more to make sure:

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 24, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase bf13b24692ce5b96cb8a9fd4a3d11c0e170dbccf --onto ba3f2b3ecf8967410f3498e2835b883601f03967. (2024-11-24 05:57:10)

@leanprover leanprover deleted a comment from leanprover-bot Nov 24, 2024
@kim-em kim-em added this pull request to the merge queue Nov 24, 2024
Merged via the queue into master with commit 884a9ea Nov 24, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants