-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split Lean.Kernel.Environment
from Lean.Environment
#5145
base: kernel-env-base
Are you sure you want to change the base?
Conversation
Hi @Kha, this sounds exciting. I don't understand the appreciation (TCB); spelling it out may help others here. Most importantly, let me not distract you from your mission towards more parallelism in the lean compilation. It is exciting to see progress here. |
I got it. TCB = Trusted Code Base |
4aebbe2
to
4ba7bdc
Compare
!bench |
Here are the benchmark results for commit 4ba7bdc. Benchmark Metric Change
=====================================================
- big_omega.lean MT task-clock 13.7% (12.0 σ)
- big_omega.lean MT wall-clock 13.7% (12.4 σ)
- bv_decide_mul branch-misses 2.0% (12.3 σ)
- bv_decide_realworld branch-misses 1.2% (31.5 σ)
- rbmap_fbip task-clock 4.1% (18.2 σ)
- rbmap_fbip wall-clock 4.1% (18.2 σ) |
@Kha This PR has update stage0 commits. So, squash should not be used, and the commit messages should be fixed. |
Mathlib CI status (docs):
|
Here are the benchmark results for commit e0353ed. Benchmark Metric Change
===============================================
- bv_decide_mul branch-misses 1.0% (13.8 σ) |
This PR clarifies Lean's Trusted Code Base (TCB) by splitting the data used by the kernel from the data used by general elaboration and code generation, and in the future asynchronously elaborated declarations.
initQuot
is moved from an environment header field to a direct environment as it is the only header field used by the kernel; this also makes the remaining header immutable after importOptions
to the interpreter such aspreferNative
(not implemented yet).