Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: merge several style syntax linters #19547

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Nov 27, 2024

Does this improve performance? To be determined!


Opening just for benchmarking purposes. Would need clean-up before it can be merged.

Open in Gitpod

@grunweg grunweg added WIP Work in progress t-linter Linter labels Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

PR summary 9bf1d50992

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cdotLinter.findErrors
+ jointSyntaxLinter
++++ findErrors
- setOptionLinter

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Collaborator Author

grunweg commented Nov 27, 2024

Benchmarking this, once CI is done, would be welcome.

@grunweg
Copy link
Collaborator Author

grunweg commented Nov 27, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 9bf1d50.
There were no significant changes against commit b5fb043.

@adomani
Copy link
Collaborator

adomani commented Nov 28, 2024

I don't know what happened to the bench summary bot: locally, it prints


File Instructions %
build -253.872⬝10⁹ (-0.17%)
Mathlib.Tactic.Linter.Style +1.584⬝10⁹ (+23.57%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-bench t-linter Linter WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants