Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds landing page scaffolding #641

Merged

Conversation

Eein
Copy link
Contributor

@Eein Eein commented Oct 30, 2024

What

Adds the landing page scaffolding for games list and the side about panel.

Have a couple of common test cases to verify rendering doesn't look weird.

These components can likely be more atomic, but would make more sense when styling.

Since intitial commit:

  • added getLeaderboards to apiClient (this does not include the use of queries yet)
  • cleans up some responsive design bits
  • uses key for v-loop
  • Removed: adds leaderboardgg colors to extend in tailwind.config.js - this is currently set to override, as the design team may want something else down the road. they are named very specifically as to not override the existing colors
  • update: removes unnecessary interaction for scaffolding

Remaining Work

  • Use actual links for the leaderboards
  • temporary styling to make it more cohesive
  • Mock backend tests

Link to Issue

Tangentially related to #639

Acceptance

Simple "should render" tests are provided

Steps for testing

Should render.

Images

image

Copy link

netlify bot commented Oct 30, 2024

👷 Deploy request for lbgg pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 66710c9

@Eein Eein force-pushed the feat/add-landing-page-scaffolding branch 3 times, most recently from 0689bd1 to 100ef47 Compare October 30, 2024 07:18
Copy link
Contributor

@TheTedder TheTedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the Leaderboard names lighting up on hover but it would be great if there was some way to tell that they were clickable links without having to hover over them. Maybe style them with an underline?

Copy link
Member

@buffet-time buffet-time left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 change

components/blocks/Landing/Landing.vue Outdated Show resolved Hide resolved
@Eein Eein force-pushed the feat/add-landing-page-scaffolding branch from 1362a4d to 6db44a0 Compare November 2, 2024 22:04
@TheTedder TheTedder linked an issue Nov 2, 2024 that may be closed by this pull request
@Eein
Copy link
Contributor Author

Eein commented Nov 2, 2024

Rebased, and made the changes requested -

Removed the mocks completely since this isn't doing any integration tests - more or less copy pasted from elsewhere which is why it was the way it is.

@Eein Eein requested review from TheTedder and buffet-time November 2, 2024 22:34
@buffet-time buffet-time merged commit 9268ab5 into leaderboardsgg:main Nov 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaderboard List View
3 participants