-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds landing page scaffolding #641
feat: adds landing page scaffolding #641
Conversation
👷 Deploy request for lbgg pending review.Visit the deploys page to approve it
|
0689bd1
to
100ef47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the Leaderboard names lighting up on hover but it would be great if there was some way to tell that they were clickable links without having to hover over them. Maybe style them with an underline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 1 change
chore: adds tests
chore: undo unneeded shared interface chore: remove old todo chore: add test to LandingLeaderboards
chore: remove unused code chore: remove unused code
1362a4d
to
6db44a0
Compare
Rebased, and made the changes requested - Removed the mocks completely since this isn't doing any integration tests - more or less copy pasted from elsewhere which is why it was the way it is. |
What
Adds the landing page scaffolding for games list and the side about panel.
Have a couple of common test cases to verify rendering doesn't look weird.
These components can likely be more atomic, but would make more sense when styling.
Since intitial commit:
tailwind.config.js
- this is currently set to override, as the design team may want something else down the road. they are named very specifically as to not override the existing colorsRemaining Work
Link to Issue
Tangentially related to #639
Acceptance
Simple "should render" tests are provided
Steps for testing
Should render.
Images