bug/LBGG-590: Persistent login #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lbgg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
zysim
reviewed
Jun 19, 2024
|
|
||
| export const useCookieMock = vi.fn((key: string, opts?: CookieOptions) => { | ||
| const cookie = toRef(cookies, key) | ||
| if (cookie.value === undefined && opts?.default) { |
There was a problem hiding this comment.
What happens if both cookie and opts.default don't have values? Won't we be returning an undefined ref?
There was a problem hiding this comment.
I think that's actually just how regular cookies work anyway.
buffet-time
approved these changes
Jun 19, 2024
TheTedder
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enables persistent logins across multiple tabs and windows by storing session data in a cookie
Changes
useCookieout in the testsLink to Issue
Closes #590
Acceptance
Steps for testing