Create Account Confirmation Resend Button Thingy #609
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 91c3dfe |
|
Where is the button to resend the confirmation email? I can't find it. |
It's hard to see in the screenshot, but it's near the top left of the dashboard. And it's only there if you're logged in as an unconfirmed user. I don't have a "real" placement for it right now, as we don't have a design for it. |
erunks
force-pushed
the
createResendConfirmationLink
branch
from
f59fb2d to
3a732a2
Compare
| @@ -10,6 +14,7 @@ export async function useGetUserDetail( | |||
| const { onError, onOkay } = opts | |||
| const responseData = ref<UserViewModel>({ | |||
| id: '', | |||
| role: 'Banned', | |||
There was a problem hiding this comment.
Why is Banned the default?
There was a problem hiding this comment.
Empty strings aren't allow based on the type of the property, so by default I assumed Banned would be best since it would act like a user is not signed in
There was a problem hiding this comment.
That feels like a hack. Is it possible to just use an empty object for the whole viewmodel instead? Maybe there's some other pattern that would work here.
There was a problem hiding this comment.
This is a great example of where typescript hurts more than it helps. You should just be able to initialize it with a null value and then assume that it's not null if the fetch operation succeeds.
There was a problem hiding this comment.
What's the update on this? I believe there was a discussion in chat, right?
There was a problem hiding this comment.
We could just add an empty string to UserRole, tbh. We would know in-code that we're in a logged out state if we see an empty string.
|
Obsoleted by #622. |
What
Frontend for resending the account confirmation email.
Link to Issue
Closes #592
Acceptance
Steps for testing
Any steps needed to test the feature (if applicable)
Images
Temp UI for now. Personally don't even like having a modal here; I'd prefer a toast: