Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBGG-564: Account confirmation #580

Merged
merged 11 commits into from
Nov 29, 2023
Merged

LBGG-564: Account confirmation #580

merged 11 commits into from
Nov 29, 2023

Conversation

erunks
Copy link
Contributor

@erunks erunks commented Nov 23, 2023

What

Enables the user to confirm their account from the link provided in their signup confirmation email.

Changes

  • Updated
    • API library
  • Created
    • useConfirmAccount composable
    • components
      • BasicAlert
      • Loader
    • /confirm-account route
  • Fixed
    • version requirements in package
    • rendering error messages on signup

Link to Issue

Closes #564

Acceptance

Steps for testing

  • Run the latest version of the backend
  • Sign up for a new account with an email
  • Click the account confirmation link in the email from the sign up
  • Should confirm your account with a success notification
  • Use the confirmation link again
  • Should show an error notification after the redirect

Images

State Image
Attempting to confirm account image
Confirmation successful image
Confirmation failed image

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for lbgg ready!

Name Link
🔨 Latest commit b077c9f
🔍 Latest deploy log https://app.netlify.com/sites/lbgg/deploys/6565640a21f27500084fa87f
😎 Deploy Preview https://deploy-preview-580--lbgg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@erunks erunks self-assigned this Nov 23, 2023
@erunks erunks marked this pull request as ready for review November 23, 2023 04:51
@erunks erunks requested a review from buffet-time November 23, 2023 04:51
assets/sprite/svg/circle-check.svg Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
components/blocks/cards/BasicAlert/BasicAlert.vue Outdated Show resolved Hide resolved
composables/api/useConfirmAccount/index.ts Outdated Show resolved Hide resolved
@erunks erunks force-pushed the LBGG-564-account-confirmation branch from 30b43e4 to 3309b0c Compare November 28, 2023 03:51
@erunks erunks force-pushed the LBGG-564-account-confirmation branch from 3309b0c to b077c9f Compare November 28, 2023 03:52
@erunks erunks merged commit ab475f1 into main Nov 29, 2023
13 checks passed
@erunks erunks deleted the LBGG-564-account-confirmation branch November 29, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: After account creation, a user's nominated email address needs to be confirmed.
3 participants