Maintenance: Upgraded all packages. (#630)

* maintenance: upgraded all packages, many changes for ESLint 9 migration, and many imports that were remove * updated version of each step in CI * updated version of each step in CI * updated version of each step in CI * updated version of each step in CI * testing ci changes * testing ci changes * testing ci changes * testing ci changes * removed globals from vitest config * readded globals for tests
leaderboardsgg · Aug 16, 2024 · fd0d83e · fd0d83e
1 parent 0045cf0
commit fd0d83e
Show file tree

Hide file tree

Showing 27 changed files with 2,591 additions and 3,910 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,27 +25,16 @@ jobs:
 
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Read package.json
         id: package
         uses: juliangruber/read-file-action@v1
         with:
           path: ./package.json
 
-      # Ensures pnpm version is consistent and gets back the value to be used in pnpm setup action
-      - name: Get PNPM version
-        id: pnpm-version
-        uses: buffet-time/[email protected]
-        with:
-          # engines.pnpm
-          packageJson-engines-pnpm: '${{ fromJson(steps.package.outputs.content).engines.pnpm }}'
-
-          # packageManager
-          packageJson-packageManager: '${{ fromJson(steps.package.outputs.content).packageManager }}'
-
       - name: Cache PNPM modules
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         id: cache-modules
         with:
           path: |
@@ -54,11 +43,9 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: ${{ runner.os }}-node-
 
-      - uses: pnpm/[email protected]
-        with:
-          version: '${{ steps.pnpm-version.outputs.version }}'
+      - uses: pnpm/action-setup@v4
 
-      - uses: actions/setup-node@v3.8.2
+      - uses: actions/setup-node@v4
         with:
           # use the version found in `.nvmrc`
           node-version-file: '.nvmrc'
@@ -71,16 +58,7 @@ jobs:
       - name: Copy `.env.test` -> `.env`
         run: cp .env.test .env
 
-      - name: Cache build
-        uses: actions/cache@v3
-        id: cache-build
-        with:
-          path: .nuxt/
-          key: ${{ runner.os }}-build-${{ hashFiles('**/.nuxt') }}
-          restore-keys: ${{ runner.os }}-build-
-
       - name: Build the `.nuxt` directory
-        if: steps.cache-build.outputs.cache-hit != 'true'
         run: pnpm build
 
       - name: Tests

diff --git a/.github/workflows/code_quality.yml b/.github/workflows/code_quality.yml
@@ -16,27 +16,16 @@ jobs:
 
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Read package.json
         id: package
         uses: juliangruber/read-file-action@v1
         with:
           path: ./package.json
 
-      # Ensures pnpm version is consistent and gets back the value to be used in pnpm setup action
-      - name: Get PNPM version
-        id: pnpm-version
-        uses: buffet-time/[email protected]
-        with:
-          # engines.pnpm
-          packageJson-engines-pnpm: '${{ fromJson(steps.package.outputs.content).engines.pnpm }}'
-
-          # packageManager
-          packageJson-packageManager: '${{ fromJson(steps.package.outputs.content).packageManager }}'
-
       - name: Cache PNPM modules
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         id: cache-modules
         with:
           path: |
@@ -45,36 +34,21 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: ${{ runner.os }}-node-
 
-      - uses: pnpm/[email protected]
-        with:
-          version: '${{ steps.pnpm-version.outputs.version }}'
+      - uses: pnpm/action-setup@v4
 
-      - uses: actions/setup-node@v3.8.2
+      - uses: actions/setup-node@v4
         with:
           # use the version found in `.nvmrc`
           node-version-file: '.nvmrc'
 
-      # shows current pnpm version
-      - name: check pnpm version
-        run: pnpm -v
-
       - name: Install `node_modules`
         if: steps.cache-modules.outputs.cache-hit != 'true'
         run: pnpm install
 
       - name: Copy `.env.test` -> `.env`
         run: cp .env.test .env
 
-      - name: Cache build
-        uses: actions/cache@v3
-        id: cache-build
-        with:
-          path: .nuxt/
-          key: ${{ runner.os }}-build-${{ hashFiles('**/.nuxt') }}
-          restore-keys: ${{ runner.os }}-build-
-
       - name: Build the `.nuxt` directory
-        if: steps.cache-build.outputs.cache-hit != 'true'
         run: pnpm build
 
       - name: Linting

diff --git a/.github/workflows/update-api.yml b/.github/workflows/update-api.yml
@@ -16,27 +16,16 @@ jobs:
 
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Read package.json
         id: package
         uses: juliangruber/read-file-action@v1
         with:
           path: ./package.json
 
-      # Ensures pnpm version is consistent and gets back the value to be used in pnpm setup action
-      - name: Get PNPM version
-        id: pnpm-version
-        uses: buffet-time/[email protected]
-        with:
-          # engines.pnpm
-          packageJson-engines-pnpm: '${{ fromJson(steps.package.outputs.content).engines.pnpm }}'
-
-          # packageManager
-          packageJson-packageManager: '${{ fromJson(steps.package.outputs.content).packageManager }}'
-
       - name: Cache PNPM modules
-        uses: actions/cache@v3.7.0
+        uses: actions/cache@v4
         id: cache-modules
         with:
           path: |
@@ -45,37 +34,22 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: ${{ runner.os }}-node-
 
-      - uses: pnpm/[email protected]
-        with:
-          version: '${{ steps.pnpm-version.outputs.version }}'
+      - uses: pnpm/action-setup@v4
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
           # use the version found in `.nvmrc`
           node-version-file: '.nvmrc'
           cache: 'pnpm'
 
-      # shows current pnpm version
-      - name: check pnpm version
-        run: pnpm -v
-
       - name: Install `node_modules`
         if: steps.cache-modules.outputs.cache-hit != 'true'
         run: pnpm install
 
       - name: Copy `.env.test` -> `.env`
         run: cp .env.test .env
 
-      - name: Cache build
-        uses: actions/cache@v3
-        id: cache-build
-        with:
-          path: .nuxt/
-          key: ${{ runner.os }}-build-${{ hashFiles('**/.nuxt') }}
-          restore-keys: ${{ runner.os }}-build-
-
       - name: Build the `.nuxt` directory
-        if: steps.cache-build.outputs.cache-hit != 'true'
         run: pnpm build
 
       - name: Run the API generation
@@ -100,7 +74,7 @@ jobs:
           git push origin ${{ steps.branch.outputs.BRANCH_NAME }}
 
       - name: Create PR
-        uses: actions/github-script@v6
+        uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.WORKFLOW_ACCESS_TOKEN }}
           script: |

diff --git a/components/blocks/LeaderboardInfo/Desktop/Desktop.test.ts b/components/blocks/LeaderboardInfo/Desktop/Desktop.test.ts
@@ -1,4 +1,3 @@
-import { vi } from 'vitest'
 import { mountSuspended } from '@nuxt/test-utils/runtime'
 import { getByTestId } from 'root/testUtils'
 import Desktop from './Desktop.vue'

diff --git a/components/blocks/LeaderboardInfo/LeaderboardInfo.test.ts b/components/blocks/LeaderboardInfo/LeaderboardInfo.test.ts
@@ -1,4 +1,3 @@
-import { vi } from 'vitest'
 import { mountSuspended } from '@nuxt/test-utils/runtime'
 import { getByTestId } from 'root/testUtils'
 import LeaderboardInfo from './LeaderboardInfo.vue'

diff --git a/components/blocks/LeaderboardInfo/Mobile/Mobile.test.ts b/components/blocks/LeaderboardInfo/Mobile/Mobile.test.ts
@@ -1,4 +1,3 @@
-import { vi } from 'vitest'
 import { mountSuspended } from '@nuxt/test-utils/runtime'
 import { getByTestId } from 'root/testUtils'
 import Mobile from './Mobile.vue'

diff --git a/components/blocks/SiteFooter/LanguageSelector/LanguageSelector.vue b/components/blocks/SiteFooter/LanguageSelector/LanguageSelector.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { type ComputedRef } from 'vue'
+import type { ComputedRef } from 'vue'
 // import { type LocaleObject } from '#imports'
 
 const NuxtI18n = useI18n()

diff --git a/components/blocks/cards/BasicAlert/BasicAlert.test.ts b/components/blocks/cards/BasicAlert/BasicAlert.test.ts
@@ -5,9 +5,9 @@ import BasicAlert from './BasicAlert.vue'
 beforeEach(() => {
   const { state: modalAlertState } = useModalAlert()
   modalAlertState.value = {
+    title: 'A test alert?',
     body: 'This is a test',
     show: true,
-    title: 'A test alert?',
     type: 'info',
   }
 })

diff --git a/components/blocks/cards/ForgotPasswordCard/ForgotPasswordCard.vue b/components/blocks/cards/ForgotPasswordCard/ForgotPasswordCard.vue
@@ -18,8 +18,7 @@ interface ForgotPasswordCardState {
 }
 
 const emit = defineEmits<{
-  (event: 'close'): void
-  (event: 'cancelClick'): void
+  (event: 'close' | 'cancelClick'): void
 }>()
 
 const props = withDefaults(defineProps<ForgotPasswordCardPops>(), {

diff --git a/components/blocks/cards/LogInCard/LogInCard.vue b/components/blocks/cards/LogInCard/LogInCard.vue
@@ -20,9 +20,7 @@ interface LogInCardState {
 }
 
 const emit = defineEmits<{
-  (event: 'close'): void
-  (event: 'forgotPasswordClick'): void
-  (event: 'signUpClick'): void
+  (event: 'close' | 'forgotPasswordClick' | 'signUpClick'): void
 }>()
 
 const props = withDefaults(defineProps<LogInCardProps>(), {
@@ -160,7 +158,7 @@ async function login() {
 
 #hide-show-password {
   @apply hidden sm:inline;
-  @apply text-gray-700 hover:bg-gray-100 bg-gray-100 hover:bg-gray-300;
+  @apply text-gray-700 bg-gray-100 hover:bg-gray-300;
 }
 
 #sign-up-button {

diff --git a/components/blocks/cards/SignUpCard/SignUpCard.vue b/components/blocks/cards/SignUpCard/SignUpCard.vue
@@ -28,9 +28,7 @@ interface UserRegister {
 }
 
 const emit = defineEmits<{
-  (event: 'close'): void
-  (event: 'logInClick'): void
-  (event: 'signUpClick'): void
+  (event: 'close' | 'logInClick' | 'signUpClick'): void
 }>()
 
 const props = withDefaults(defineProps<SignUpCardProps>(), {
@@ -271,7 +269,7 @@ function validatePasswordInputs() {
 
     #hide-show-password {
       @apply hidden sm:inline;
-      @apply text-gray-700 hover:bg-gray-100 bg-gray-100 hover:bg-gray-300;
+      @apply text-gray-700  bg-gray-100 hover:bg-gray-300;
     }
   }
 

diff --git a/composables/api/useChangePassword/index.ts b/composables/api/useChangePassword/index.ts
@@ -16,6 +16,7 @@ export async function useChangePassword(
     baseUrl: useRuntimeConfig().public.backendBaseUrl,
   })
 
+  // eslint-disable-next-line @typescript-eslint/no-invalid-void-type
   return await useApi<void>(
     async () => await account.recoverCreate2(token, requestData),
     {