Address comments

leaderboardsgg · May 10, 2024 · 0517c5b · 0517c5b
1 parent b4873f6
commit 0517c5b
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 41 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
diff --git a/components/blocks/LeaderboardInfo/LeaderboardInfo.vue b/components/blocks/LeaderboardInfo/LeaderboardInfo.vue
@@ -25,15 +25,15 @@ defineProps<LeaderboardInfoProps>()
 </script>
 
 <template>
-  <Desktop
-    v-if="!isMobile"
+  <Mobile
+    v-if="isMobile"
     data-testid="child"
     :leaderboard="leaderboard"
     :todo-platforms="todoPlatforms"
     @follow="emit('follow', leaderboard.id)"
   />
-  <Mobile
-    v-if="isMobile"
+  <Desktop
+    v-else
     data-testid="child"
     :leaderboard="leaderboard"
     :todo-platforms="todoPlatforms"

diff --git a/components/elements/buttons/Dropdown/Dropdown.test.ts b/components/elements/buttons/Dropdown/Dropdown.test.ts
@@ -1,8 +1,11 @@
-import { enableAutoUnmount, mount } from '@vue/test-utils'
+import {
+  enableAutoUnmount,
+  mount,
+  type ComponentMountingOptions,
+} from '@vue/test-utils'
 import { getByTestId } from 'root/testUtils'
 import Dropdown from './Dropdown.vue'
 import DropdownItem from './DropdownItem.vue'
-import type { ComponentMountingOptions } from '@vue/test-utils'
 
 enableAutoUnmount(afterEach)
 

diff --git a/components/elements/buttons/Dropdown/Dropdown.vue b/components/elements/buttons/Dropdown/Dropdown.vue
@@ -1,8 +1,7 @@
 <script setup lang="ts">
 // Explicitly-importing these because tests don't like the auto-imports - zysim
-import { provide, ref } from 'vue'
+import { provide, ref, type Ref } from 'vue'
 import BaseButton from '../BaseButton/BaseButton.vue'
-import type { Ref } from 'vue'
 
 export interface SharedState {
   active: Ref<boolean>

diff --git a/composables/api/useGetLeaderboardDetail/index.ts b/composables/api/useGetLeaderboardDetail/index.ts
@@ -1,7 +1,10 @@
 import { ref } from 'vue'
-import { useApi } from 'composables/useApi'
+import {
+  useApi,
+  type ApiResponse,
+  type optionalParameters,
+} from 'composables/useApi'
 import { Leaderboards } from 'lib/api/Leaderboards'
-import type { ApiResponse, optionalParameters } from 'composables/useApi'
 import type { LeaderboardViewModel } from 'lib/api/data-contracts'
 
 export async function useGetLeaderboardDetail(

diff --git a/lib/api/Account.ts b/lib/api/Account.ts
@@ -19,8 +19,7 @@ import type {
   UserViewModel,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Account<
   SecurityDataType = unknown,

diff --git a/lib/api/Categories.ts b/lib/api/Categories.ts
@@ -15,8 +15,7 @@ import type {
   ProblemDetails,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Categories<
   SecurityDataType = unknown,

diff --git a/lib/api/Leaderboards.ts b/lib/api/Leaderboards.ts
@@ -16,8 +16,7 @@ import type {
   ProblemDetails,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Leaderboards<
   SecurityDataType = unknown,

diff --git a/lib/api/Runs.ts b/lib/api/Runs.ts
@@ -16,8 +16,7 @@ import type {
   RunViewModel,
   ValidationProblemDetails,
 } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { ContentType, HttpClient } from './http-client'
+import { ContentType, HttpClient, type RequestParams } from './http-client'
 
 export class Runs<
   SecurityDataType = unknown,

diff --git a/lib/api/Users.ts b/lib/api/Users.ts
@@ -10,8 +10,7 @@
  */
 
 import type { ProblemDetails, UserViewModel } from './data-contracts'
-import type { RequestParams } from './http-client'
-import { HttpClient } from './http-client'
+import { HttpClient, type RequestParams } from './http-client'
 
 export class Users<
   SecurityDataType = unknown,