This repository has been archived by the owner on Mar 12, 2023. It is now read-only.
Refer to .NET Project #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zysim
added a commit
to zysim/leaderboard-backend-go
that referenced
this pull request
Jun 28, 2022
* Create Files * Change Model Fields * Add CreateJudgement * Return 500 as Intended, and Remove <remarks> Tags <remarks> tags don't work for non-controller actions * Add Second Condition * Get Rid of Null Mod Check We already check if the user exists in authZ, cuz we need to know if they're a mod. * Add JudgementViewModel for Controller Actions * Uncomment Admin User Check for Authz * Add RunService to Program * Simplify creating JudgementViewModels * Add/change docs to be agreeable w/ Swashbuckle Can't have fields explicitly defined in record structs; Swagger won't generate. * Fixed IsMod auth decorator and CreateJudgement * Wrote test for CreateJudgement route 200 path * Fixed IsMod to actually load modships so it doesn't always fail * CreatedAtAction was being called in a way that caused it to fail * Using Utc in example timestamp `Now` doesn't work in NPGSql, it has to be Utc ok epic * Allow admins to do mod things I forgot we said I was gonna include this too * Reorder ResponseType Attribute * Convert ViewModel to be A Public Record * Update CONTRIBUTING to link to the separate style guide * If This Actually Needs to be Done * Fix tests, move ViewModels folder Co-authored-by: Sim <[email protected]> Co-authored-by: RageCage64 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.