Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[개선] Shop 엔티티 식별자 UUID로 개선(issue#85) #87

Merged
merged 12 commits into from
Oct 11, 2023

Conversation

le2sky
Copy link
Owner

@le2sky le2sky commented Oct 10, 2023

구현 요약

  • Shop 엔티티의 식별자를 UUID로 개선했습니다.
  • Shop의 식별자인 UUID와 관련된 신규 테스트 코드를 작성했습니다.

연관 이슈
#85

@le2sky le2sky added enhancement 뭔가 개선하고 싶어 run: ci ci 과정 실행 해줘~ labels Oct 10, 2023
@le2sky le2sky self-assigned this Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Test Results

235 tests   235 ✔️  30s ⏱️
  61 suites      0 💤
  61 files        0

Results for commit 5888426.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #87 (5888426) into develop (5cd6b71) will increase coverage by 0.25%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop      #87      +/-   ##
=============================================
+ Coverage      95.94%   96.19%   +0.25%     
  Complexity       317      317              
=============================================
  Files             72       72              
  Lines            813      815       +2     
  Branches          38       38              
=============================================
+ Hits             780      784       +4     
+ Misses            18       16       -2     
  Partials          15       15              
Files Coverage Δ
...kitary/reservation/web/GetReservationController.kt 100.00% <100.00%> (ø)
...eservation/web/request/ReserveProductWebRequest.kt 100.00% <100.00%> (ø)
...in/com/mealkitary/shop/web/GetProductController.kt 100.00% <100.00%> (ø)
...mealkitary/shop/web/GetReservableTimeController.kt 100.00% <100.00%> (ø)
.../mealkitary/shop/web/UpdateShopStatusController.kt 100.00% <100.00%> (ø)
...on/application/port/input/ReserveProductRequest.kt 100.00% <100.00%> (ø)
...ation/application/service/GetReservationService.kt 100.00% <ø> (ø)
...kitary/shop/application/port/input/ShopResponse.kt 100.00% <100.00%> (ø)
...tary/shop/application/service/GetProductService.kt 100.00% <100.00%> (ø)
...op/application/service/GetReservableTimeService.kt 100.00% <ø> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner Author

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하하... 변경 파일이 이렇게 많을 줄을 몰랐네요.. domain/shop 클래스의 기존 식별자를 제거하고 UUIDBaseEntity를 적용한 것, UUID 관련 신규 테스트 코드를 작성한 것 이외에는 Long->UUID로 변경됨으로 인해 변경된 내용들입니다!

@1o18z 리뷰 부탁드립니다! 🙇🏻‍♂️🙇🏻‍♂️

@le2sky le2sky requested a review from 1o18z October 10, 2023 17:23
@1o18z
Copy link
Collaborator

1o18z commented Oct 11, 2023

파일 변경이 많은데도 매번 코멘트를 달아주셔서 보는데 전혀 어려움이 없었네요🥲🙆🏻‍♀️🥲🙆🏻‍♀️
저도 열심히 코멘트 달아봐야겠습니다 ㅎㅎ
코멘트 하나 남긴 부분 외에는 추가적으로 수정할 부분은 없어 보여요!!👍🏻
수고하셨습니다~~~🥇⭐️

@le2sky le2sky merged commit ed00405 into develop Oct 11, 2023
7 checks passed
@le2sky le2sky deleted the refactor/85 branch October 11, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 뭔가 개선하고 싶어 run: ci ci 과정 실행 해줘~
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants