-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[개선] Shop 엔티티 식별자 UUID로 개선(issue#85) #87
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Codecov Report
@@ Coverage Diff @@
## develop #87 +/- ##
=============================================
+ Coverage 95.94% 96.19% +0.25%
Complexity 317 317
=============================================
Files 72 72
Lines 813 815 +2
Branches 38 38
=============================================
+ Hits 780 784 +4
+ Misses 18 16 -2
Partials 15 15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하하... 변경 파일이 이렇게 많을 줄을 몰랐네요.. domain/shop 클래스의 기존 식별자를 제거하고 UUIDBaseEntity를 적용한 것, UUID 관련 신규 테스트 코드를 작성한 것 이외에는 Long->UUID로 변경됨으로 인해 변경된 내용들입니다!
@1o18z 리뷰 부탁드립니다! 🙇🏻♂️🙇🏻♂️
mealkitary-domain/src/main/kotlin/com/mealkitary/shop/domain/shop/Shop.kt
Show resolved
Hide resolved
mealkitary-api/src/main/kotlin/com/mealkitary/reservation/web/GetReservationController.kt
Outdated
Show resolved
Hide resolved
mealkitary-api/src/test/kotlin/com/mealkitary/shop/web/GetProductControllerTest.kt
Show resolved
Hide resolved
파일 변경이 많은데도 매번 코멘트를 달아주셔서 보는데 전혀 어려움이 없었네요🥲🙆🏻♀️🥲🙆🏻♀️ |
구현 요약
연관 이슈
#85