Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[기능 구현] 카카오 주소 조회 api 연동 (issue#84) #86

Merged
merged 14 commits into from
Oct 11, 2023

Conversation

1o18z
Copy link
Collaborator

@1o18z 1o18z commented Oct 7, 2023

구현 요약

  • 카카오 주소 정보 조회 api를 연동해 ShopAddressResolver를 구현했습니다.
  • 좌표의 타입을 카카오에서 받아오는 정보에 맞춰 String 타입으로 변경했습니다.

연관 이슈
#84

@1o18z 1o18z added new 기능 개발하고 싶어 run: gradle test 테스트 커버리지랑 결과를 알고 싶어 run: ci ci 과정 실행 해줘~ labels Oct 7, 2023
@1o18z 1o18z requested a review from le2sky October 7, 2023 12:50
@le2sky le2sky removed the run: gradle test 테스트 커버리지랑 결과를 알고 싶어 label Oct 7, 2023
@le2sky le2sky changed the base branch from main to develop October 7, 2023 12:58
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Test Results

230 tests  +3   230 ✔️ +3   37s ⏱️ +7s
  61 suites +2       0 💤 ±0 
  61 files   +2       0 ±0 

Results for commit 5cd6b71. ± Comparison against base commit 7204ea2.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #86 (5cd6b71) into develop (7204ea2) will increase coverage by 0.10%.
The diff coverage is 97.87%.

@@              Coverage Diff              @@
##             develop      #86      +/-   ##
=============================================
+ Coverage      95.83%   95.94%   +0.10%     
- Complexity       310      317       +7     
=============================================
  Files             69       72       +3     
  Lines            768      813      +45     
  Branches          37       38       +1     
=============================================
+ Hits             736      780      +44     
  Misses            18       18              
- Partials          14       15       +1     
Files Coverage Δ
...mealkitary/shop/domain/shop/factory/ShopFactory.kt 100.00% <100.00%> (ø)
...kotlin/com/mealkitary/address/KakaoApiWebClient.kt 100.00% <100.00%> (ø)
...lkitary/address/payload/KakaoApiAddressResponse.kt 100.00% <100.00%> (ø)
.../main/java/com/mealkitary/SimpleAddressResolver.kt 100.00% <100.00%> (ø)
.../com/mealkitary/address/KakaoApiAddressResolver.kt 94.11% <94.11%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@1o18z
Copy link
Collaborator Author

1o18z commented Oct 7, 2023

@le2sky 코드리뷰 부탁드립니다~!~! 🙆🏻‍♀️🍀✨

Copy link
Owner

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!!💯 몇가지 커멘트 남겨놨으니 확인 부탁드립니다 🙇🏻‍♂️

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@le2sky le2sky merged commit 194220c into develop Oct 11, 2023
7 checks passed
@le2sky le2sky deleted the feat/84 branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new 기능 개발하고 싶어 run: ci ci 과정 실행 해줘~
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants