-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[기능 구현] 카카오 주소 조회 api 연동 (issue#84) #86
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #86 +/- ##
=============================================
+ Coverage 95.83% 95.94% +0.10%
- Complexity 310 317 +7
=============================================
Files 69 72 +3
Lines 768 813 +45
Branches 37 38 +1
=============================================
+ Hits 736 780 +44
Misses 18 18
- Partials 14 15 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
@le2sky 코드리뷰 부탁드립니다~!~! 🙆🏻♀️🍀✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많으셨습니다!!💯 몇가지 커멘트 남겨놨으니 확인 부탁드립니다 🙇🏻♂️
mealkitary-domain/src/main/kotlin/com/mealkitary/common/model/Coordinates.kt
Outdated
Show resolved
Hide resolved
mealkitary-domain/src/main/kotlin/com/mealkitary/shop/domain/shop/factory/AddressResolver.kt
Show resolved
Hide resolved
...kakao-api-address-resolver/src/main/kotlin/com/mealkitary/address/KakaoApiAddressResolver.kt
Outdated
Show resolved
Hide resolved
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
구현 요약
연관 이슈
#84