Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[기능 구현] 가게 상태 변경 기능 구현(issue#72) #76

Merged
merged 37 commits into from
Sep 27, 2023
Merged

Conversation

1o18z
Copy link
Collaborator

@1o18z 1o18z commented Sep 23, 2023

구현 요약
가게의 식별자를 기반으로 예약 존재 여부를 확인하고, 가게 상태를 변경하는 기능을 구현했습니다.

연관 이슈
#72

le2sky and others added 25 commits May 17, 2023 21:12
메인 브랜치 반영
메인 브랜치 반영
메인 브랜치 반영
메인 브랜치 반영
[배포] 메인 브랜치 반영(PR#19)
[배포] 메인 브랜치 반영(PR#22, PR#24)
[배포] 메인 브랜치 반영(PR#27, PR#29)
[배포] 메인 브랜치 반영(PR#32)
[배포] 메인 브랜치 반영(PR#35)
[문제] ci yml 경로 이동(hotfix)
[배포] 메인 브랜치 반영(PR#49)
[배포] v0.3.0(PR#55, PR#57)
[배포] v0.4.0(PR#63, PR#65, PR#67)
[배포] 메인 브랜치 반영(PR#73)
@1o18z 1o18z added new 기능 개발하고 싶어 run: ci ci 과정 실행 해줘~ labels Sep 23, 2023
@1o18z 1o18z self-assigned this Sep 23, 2023
@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Test Results

192 tests   192 ✔️  22s ⏱️
  46 suites      0 💤
  46 files        0

Results for commit 2b2c20f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #76 (2b2c20f) into develop (2bc1a00) will increase coverage by 0.25%.
Report is 1 commits behind head on develop.
The diff coverage is 96.42%.

@@              Coverage Diff              @@
##             develop      #76      +/-   ##
=============================================
+ Coverage      94.61%   94.87%   +0.25%     
- Complexity       225      239      +14     
=============================================
  Files             50       52       +2     
  Lines            557      585      +28     
  Branches          26       27       +1     
=============================================
+ Hits             527      555      +28     
+ Misses            18       17       -1     
- Partials          12       13       +1     
Files Coverage Δ
.../mealkitary/shop/web/UpdateShopStatusController.kt 100.00% <100.00%> (ø)
...hop/application/service/UpdateShopStatusService.kt 100.00% <100.00%> (ø)
...ain/kotlin/com/mealkitary/shop/domain/shop/Shop.kt 83.87% <100.00%> (+6.09%) ⬆️
...persistence/SpringDataJpaShopPersistenceAdapter.kt 100.00% <100.00%> (ø)
...tlin/com/mealkitary/shop/domain/shop/ShopStatus.kt 75.00% <0.00%> (-25.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@1o18z
Copy link
Collaborator Author

1o18z commented Sep 24, 2023

@le2sky 커밋이 너무 복잡해졌네요,, 주의하겠습니다😢😢
코드리뷰 부탁드립니다! 피드백 많이 해주세요🙇🏻‍♀️🙆🏻‍♀️

Copy link
Owner

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 따봉 백만개👍

Spring Rest Docs 코드가 누락된 것 같네요! 눈물 주륵

@le2sky le2sky merged commit 2e182bb into develop Sep 27, 2023
7 checks passed
@le2sky le2sky deleted the feat/72 branch September 27, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new 기능 개발하고 싶어 run: ci ci 과정 실행 해줘~
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants