Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[개선] Location 리소스 경로 개선(issue#59) #60

Merged
merged 3 commits into from
Aug 27, 2023
Merged

Conversation

le2sky
Copy link
Owner

@le2sky le2sky commented Aug 27, 2023

구현 요약

  • 실제 반환되는 리소스 경로에서 localhost/reservation//id 형식으로 슬래시가 두개 있었습니다.
  • 슬래시를 하나만 둬 유효한 리소스 경로를 반환하도록 개선했습니다.
  • getOneReservation 컨트롤러 테스트가 포매팅 문제로 깨지는 문제를 개선했습니다.

연관 이슈
#59

@le2sky le2sky added enhancement 뭔가 개선하고 싶어 run: gpt code review 리뷰받고 싶어 run: ci ci 과정 실행 해줘~ labels Aug 27, 2023
@le2sky le2sky self-assigned this Aug 27, 2023
@github-actions
Copy link

Test Results

150 tests  ±0   150 ✔️ ±0   19s ⏱️ -8s
  37 suites ±0       0 💤 ±0 
  37 files   ±0       0 ±0 

Results for commit 74a21e9. ± Comparison against base commit fd4bff4.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #60 (74a21e9) into develop (fd4bff4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #60   +/-   ##
==========================================
  Coverage      94.07%   94.07%           
  Complexity       206      206           
==========================================
  Files             46       46           
  Lines            506      506           
  Branches          25       25           
==========================================
  Hits             476      476           
  Misses            18       18           
  Partials          12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@le2sky le2sky merged commit ed4bb13 into develop Aug 27, 2023
7 checks passed
@le2sky le2sky deleted the refactor/59 branch August 27, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 뭔가 개선하고 싶어 run: ci ci 과정 실행 해줘~ run: gpt code review 리뷰받고 싶어
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant