refactor: 메서드 인라인화

le2sky · Sep 26, 2023 · 2b2c20f · 2b2c20f
1 parent 5789df1
commit 2b2c20f
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/...cation/src/main/kotlin/com/mealkitary/shop/application/service/UpdateShopStatusService.kt b/...cation/src/main/kotlin/com/mealkitary/shop/application/service/UpdateShopStatusService.kt
@@ -15,16 +15,18 @@ class UpdateShopStatusService(
 ) : UpdateShopStatusUseCase {
 
     override fun update(shopId: Long) {
-        val shop = findShopById(shopId)
+        val shop = loadShopPort.loadOneShopById(shopId)
 
         if (shop.status.isValidStatus()) {
             checkReservationByShopId(shopId)
         }
         updateStatus(shop)
     }
 
-    private fun findShopById(shopId: Long): Shop {
-        return loadShopPort.loadOneShopById(shopId)
+    private fun checkReservationByShopId(shopId: Long) {
+        if (checkExistenceShopPort.hasReservations(shopId)) {
+            throw IllegalStateException("예약이 존재할 경우 가게 상태를 INVALID로 변경할 수 없습니다.")
+        }
     }
 
     private fun updateStatus(shop: Shop) {
@@ -34,10 +36,4 @@ class UpdateShopStatusService(
             shop.changeStatusValid()
         }
     }
-
-    private fun checkReservationByShopId(shopId: Long) {
-        if (checkExistenceShopPort.hasReservations(shopId)) {
-            throw IllegalStateException("예약이 존재할 경우 가게 상태를 INVALID로 변경할 수 없습니다.")
-        }
-    }
 }