Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework recruitment items to become datapacks #10342

Open
wants to merge 3 commits into
base: version/main
Choose a base branch
from
Open

Rework recruitment items to become datapacks #10342

wants to merge 3 commits into from
+240 −152

Conversation

Thodor12
Copy link
Contributor

Changes proposed in this pull request

  • Recruit costs use datapacks in favor of configuration values
  • Improves the recruit logic for tavern spawning and entity conversion to use similar logic

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

Raycoms
Raycoms reviewed Nov 24, 2024
View reviewed changes
src/main/java/com/minecolonies/core/event/EventHandler.java
final IVisitorData visitorData = module.spawnVisitor();
visitorData.triggerInteraction(new RecruitmentInteraction(Component.translatable(
"com.minecolonies.coremod.gui.chat.recruitstorycured", visitorData.getName().split(" ")[0]), ChatPriority.IMPORTANT));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raycoms Raycoms Raycoms left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thodor12 @Raycoms