Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify item block registry #10170

Open
wants to merge 7 commits into
base: version/1.21
Choose a base branch
from
Open

Simplify item block registry #10170

wants to merge 7 commits into from
+981 −2,509

Conversation

Nightenom
Copy link
Member

@Nightenom Nightenom commented Aug 26, 2024 •
edited
Loading

Changes proposed in this pull request:

  • api (binary) breaking change, in 1.21 its fine, however when backporting this might potentially hurt existing addons?
  • moves item/block to deferred registry, removal of initializer classes
  • removal of empty classes for registry things, possible further cleanup: removal of empty block/item classes

[x] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

Review please

Thodor12
Thodor12 previously approved these changes Aug 26, 2024
View reviewed changes
src/main/java/com/minecolonies/api/items/ModItems.java Outdated Show resolved Hide resolved
Thodor12
Thodor12 previously approved these changes Aug 26, 2024
View reviewed changes
@Nightenom Nightenom added the 1.21 label Aug 28, 2024
Raycoms
Raycoms reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Review. This is going to be a nightmare to port. Have you tested this?

src/main/java/com/minecolonies/api/colony/buildings/registry/BuildingEntry.java Outdated Show resolved Hide resolved
src/main/java/com/minecolonies/api/blocks/ModBlocks.java Outdated Show resolved Hide resolved
src/main/java/com/minecolonies/api/blocks/ModBlocks.java Show resolved Hide resolved
src/main/java/com/minecolonies/api/items/ModItems.java Outdated Show resolved Hide resolved
src/main/java/com/minecolonies/api/items/ModItems.java Outdated Show resolved Hide resolved
src/main/java/com/minecolonies/api/items/ModItems.java Show resolved Hide resolved
src/main/java/com/minecolonies/apiimp/initializer/TileEntityInitializer.java Outdated Show resolved Hide resolved
...ain/java/com/minecolonies/core/generation/defaults/workers/DefaultBakerCraftingProvider.java Show resolved Hide resolved
@Nightenom
Copy link
Member Author

@uecasm how much is this going to hit ur addons in 1.20.1? so we have some idea

@Nightenom Nightenom mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thodor12 Thodor12 Thodor12 left review comments

@Raycoms Raycoms Awaiting requested review from Raycoms

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
1.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nightenom @Raycoms @Thodor12