fix banner picker

ldtteam · Nov 15, 2024 · ba4f54d · ba4f54d
1 parent fe540c4
commit ba4f54d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/com/minecolonies/core/client/gui/WindowBannerPicker.java b/src/main/java/com/minecolonies/core/client/gui/WindowBannerPicker.java
@@ -505,18 +505,18 @@ public PatternButton(int x, int y, int height, Holder<BannerPattern> pattern)
         @Override
         public void renderWidget(final GuiGraphics stack, int mx, int my, float p_renderButton_3_)
         {
-            this.visible = scrollRow * PATTERN_COLUMNS <= this.index && this.index < PATTERN_COLUMNS * (scrollRow + PATTERN_ROWS);
+            boolean isVisible = scrollRow * PATTERN_COLUMNS <= this.index && this.index < PATTERN_COLUMNS * (scrollRow + PATTERN_ROWS);
             this.active = activeLayer != 0;
 
-            if (!this.active || !this.visible) return;
+            if (!this.active || !this.visible || !isVisible) return;
 
             int position = Math.floorDiv(this.index - scrollRow*PATTERN_COLUMNS, PATTERN_COLUMNS);
             this.setY(center(WindowBannerPicker.this.height, PATTERN_ROWS, PATTERN_HEIGHT, position, PATTERN_MARGIN));
             this.isHovered = mx >= this.getX() && my >= this.getY() && mx < this.getX() + this.width && my < this.getY() + this.height;
 
             super.renderWidget(stack, mx, my, p_renderButton_3_);
 
-            if (this.visible)
+            if (isVisible)
             {
                 if (this.isHovered && this.active)
                     stack.fill(this.getX(), this.getY(), this.getX()+this.width, this.getY()+this.height, 0xDDFFFFFF);