Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update worker.mdoc #1074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update worker.mdoc #1074

wants to merge 1 commit into from

Conversation

Corbi84
Copy link

@Corbi84 Corbi84 commented Sep 30, 2024

Edited the level 0 tool description from Wood or Gold to Stone, as per message https://discord.com/channels/139070364159311872/1284909613401247785/1290077429687255051

Cheers,
Corbi

Closes #

Changes proposed:

Edited the level 0 tool description from Wood or Gold to Stone, as per message https://discord.com/channels/139070364159311872/1284909613401247785/1290077429687255051

Cheers,
Corbi
@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Thodor12
Copy link
Collaborator

Hey, thanks for your contribution.

Please sign the CLA so this may be merged.

@@ -31,7 +31,7 @@ For example, Unbreaking II counts as 2 enchantments, Efficiency V counts as 5 en

| Work Hut Level | Max Tool/Sword Level |
| -------------- | ---------------------------------------------------------------------------------------------------------------------------------------- |
| 0 | Wood or Gold + 0 enchantments |
| 0 | Stone + 0 enchantments |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here is not quite correct, as this is only applicable to builders, whilst this list is meant for any worker.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I have not seen any other worker that can be a level 0, so it would be "any". ;-)

Apart from the technicality: I did not mention the (or wood/gold) part, so it would be more elegant to stick to the same format anyhow, as in "Stone + 0 enchantments (OR Wood/Gold + 1 enchantment); only applicable for builder profession"


Apart from that change, according to MotionlessTrain the enchantment "counting" appears to have been changed to look for the highest level present only, instead of adding up all levels of existing enchantments, so that part needs an update as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants