Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Simplified Chinese localization #158

Open
wants to merge 1 commit into
base: version/latest
Choose a base branch
from

Conversation

EndsM
Copy link

@EndsM EndsM commented Jul 14, 2023

I have placed it with the generated english localization file.

I have placed it with the generated english localization file.
@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@EndsM
Copy link
Author

EndsM commented Jul 14, 2023

And I noticed that, there was a localization for Vietnamese before, but was removed during commit f90af33. Was that removed intentionally, or accidentally removed by datagen system?

@Thodor12
Copy link
Contributor

This will in fact be removed automatically, we use a system called datagenerators, made by Forge, to automatically generate translation files and more.
Translations in our other projects are actually managed by Crowdin, an online translation service. Although that doesn't seem to be set up for Domum.

@EndsM
Copy link
Author

EndsM commented Jul 14, 2023

Well, I am not an expert on Java, but I search through the project to see things around the datagen services. It seems that the string of each block are write here as entry for each type of things(doors, fences, etc), and organized using languageProvider in global package, then called during GatherDataEvent in handler.
There are seems no method for gathering translation from corwdin via their API, and upload things to crowdin in GlobalLanguageProvider class. By the way, the credential for crowdin seems stored into settings.kts, I don't know will that cause some problems. But it doesn't seems like an credential token, consider the credentialsJSON here are more like a GUID.
My brain are shaking cause is 2am here, so I think I just write a bunch of gibberish here :D

@Thodor12
Copy link
Contributor

Although that doesn't seem to be set up for Domum.

Crowdin is not configured for this project. Normally what happens is that the GlobalLanguageProvider asks the translations from Crowdin and then builds the files using that.

All I know is that we don't support in project translations, hence why there are 3 open PR's all for adding translations.

@EndsM
Copy link
Author

EndsM commented Jul 14, 2023

I see, actually curiosity just drives me to check how crowdin integration works. After reference the minecolonies project, I think the management of translation are not done in code actually. Maybe it was done in IDE or TeamCity side things, but I'm unfamiliar with this workflow, so I just stop there. Well, thanks for answering, and I think I have a lot of fun research topic around Minecraft mod localisation after this pull request. (And a sleepless night). Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants