-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Simplified Chinese localization #158
base: version/latest
Are you sure you want to change the base?
Conversation
I have placed it with the generated english localization file.
|
And I noticed that, there was a localization for Vietnamese before, but was removed during commit f90af33. Was that removed intentionally, or accidentally removed by datagen system? |
This will in fact be removed automatically, we use a system called datagenerators, made by Forge, to automatically generate translation files and more. |
Well, I am not an expert on Java, but I search through the project to see things around the datagen services. It seems that the string of each block are write here as entry for each type of things(doors, fences, etc), and organized using languageProvider in global package, then called during GatherDataEvent in handler. |
Crowdin is not configured for this project. Normally what happens is that the GlobalLanguageProvider asks the translations from Crowdin and then builds the files using that. All I know is that we don't support in project translations, hence why there are 3 open PR's all for adding translations. |
I see, actually curiosity just drives me to check how crowdin integration works. After reference the minecolonies project, I think the management of translation are not done in code actually. Maybe it was done in IDE or TeamCity side things, but I'm unfamiliar with this workflow, so I just stop there. Well, thanks for answering, and I think I have a lot of fun research topic around Minecraft mod localisation after this pull request. (And a sleepless night). Thanks |
I have placed it with the generated english localization file.