Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added <O extends SaxesOptions> #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

biojet1
Copy link

@biojet1 biojet1 commented Sep 15, 2022

my node typescript project got compilation error TS2344

tsc -d --sourcemap

Error: node_modules/saxes/saxes.d.ts(46,71): error TS2344: Type 'O' does not satisfy the constraint 'SaxesOptions'.
  Type 'O' is not assignable to type 'CommonOptions'.
Error: node_modules/saxes/saxes.d.ts(55,80): error TS2344: Type 'O' does not satisfy the constraint 'SaxesOptions'.
  Type 'O' is not assignable to type 'CommonOptions'.
Error: node_modules/saxes/saxes.d.ts(62,61): error TS2344: Type 'O' does not satisfy the constraint 'SaxesOptions'.
  Type 'O' is not assignable to type 'CommonOptions'.
Error: node_modules/saxes/saxes.d.ts(69,62): error TS2344: Type 'O' does not satisfy the constraint 'SaxesOptions'.
  Type 'O' is not assignable to type 'CommonOptions'.
Error: Process completed with exit code 2.

typescript version is

$ tsc --version
Version 4.8.3

with this pull request i can compile it now

i think typescript 4.8.3 became stricter

@tpluscode
Copy link

tpluscode commented Mar 19, 2023

Could this be merged?

@rubensworks
Copy link

FYI, I also ran into this issue, and ended up forking the project (https://github.com/rubensworks/saxes), and releasing under @rubensworks/saxes.
Happy to dissolve my fork as soon as this PR gets merged.

@jonathan-rosa jonathan-rosa mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants