Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dcompute] don't crash on VarDelarations with no type #4504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Dcompute] don't crash on VarDelarations with no type #4504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de345b6
[Dcompute] don't crash on `VarDelaration`s with no type
thewilsonator Sep 27, 2023
14aba03
Update dcompute_enum.d
thewilsonator Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion gen/semantic-dcompute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,11 @@ struct DComputeSemanticAnalyser : public StoppableVisitor {
return;
}

if (decl->type->ty == TY::Taarray) {
if (!decl->type) {
stop = true;
return;
}
else if (decl->type->ty == TY::Taarray) {
decl->error("associative arrays not allowed in `@compute` code");
stop = true;
}
Expand Down
19 changes: 19 additions & 0 deletions tests/semantic/dcompute_enum.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// RUN: %ldc -o- -mdcompute-targets=cuda-430 %s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this should be cuda-350, 430 is not a valid number, not sure why this is passing, is it not running?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS: LDC :: semantic/dcompute_enum.d (348 of 355)

Maybe only verified when actually generating code without -o-?

// REQUIRES: target_NVPTX
@compute(CompileFor.deviceOnly) module dcompute_enum;
pragma(LDC_no_moduleinfo);
import ldc.dcompute;
template isUnsigned(T)
{
static if (!__traits(isUnsigned, T))
enum isUnsigned = false;
else static if (is(T U == enum))
enum isUnsigned = isUnsigned!U;
else
enum isUnsigned = __traits(isZeroInit, T) // Not char, wchar, or dchar.
&& !is(immutable T == immutable bool) && !is(T == __vector);
}
@kernel void tst (uint* dst)
{
dst[0] = isUnsigned!(typeof(dst[0]));
}
Loading