Add pragma(LDC_no_moduleinfo) to all gccbuiltin generated .di files. #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moduleinfo is not needed, because there are no module ctors, nor unittests, etc. This prevents missing Moduleinfo symbol linking problems for some use cases.
|
Do we do the check the other way around? I think we only check for I think this can be extended to any |
I'm a bit wary of just blanket removing moduleinfo without needing to do so. But I've removed it from ldc.profile too (that module is intentionally template-only and not linking into druntime). |
|
converted to draft, this actually does not fix issue #4442 |
|
why draft, it's simple, this does not fix #4442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moduleinfo is not needed, because there are no module ctors, nor unittests, etc. This prevents missing Moduleinfo symbol linking problems for some use cases.
Resolves #4442