Merge pull request #114 from ldbc/exception-handling

Throw RuntimeExceptions to fail as early as possible
ldbc · Feb 5, 2020 · e6213b5 · e6213b5
2 parents 4e0fa45 + 753a414
commit e6213b5
Show file tree

Hide file tree

Showing 34 changed files with 45 additions and 52 deletions.
diff --git a/src/main/java/ldbc/snb/datagen/LdbcDatagen.java b/src/main/java/ldbc/snb/datagen/LdbcDatagen.java
@@ -348,7 +348,6 @@ public static void main(String[] args) throws Exception {
         } catch (Exception e) {
             System.err.println("Error during execution");
             System.err.println(e.getMessage());
-            e.printStackTrace();
             throw e;
         }
     }

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/BrowserDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/BrowserDictionary.java
@@ -73,7 +73,7 @@ private void load(String fileName) {
             }
             dictionary.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/CompanyDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/CompanyDictionary.java
@@ -114,7 +114,7 @@ private void load(String fileName) {
             }
             dictionary.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/EmailDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/EmailDictionary.java
@@ -86,7 +86,7 @@ private void load(String fileName) {
             }
             emailDictionary.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/IPAddressDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/IPAddressDictionary.java
@@ -119,7 +119,7 @@ private void load(String mappingFileName, String baseIPdir) {
                 ipZoneFile.close();
             }
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/LanguageDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/LanguageDictionary.java
@@ -124,7 +124,7 @@ private void load(String fileName) {
             }
             dictionary.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/NamesDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/NamesDictionary.java
@@ -110,7 +110,7 @@ public void extractSurNames() {
             surnameDictionary.close();
             System.out.println("Done ... " + totalSurNames + " surnames were extracted ");
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 
@@ -140,7 +140,7 @@ public void extractGivenNames() {
             givennameDictionary.close();
             System.out.println("Done ... " + totalGivenNames + " given names were extracted ");
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/PlaceDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/PlaceDictionary.java
@@ -291,7 +291,7 @@ private void readCities(String fileName) {
             }
             dictionary.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 
@@ -331,7 +331,7 @@ private void readCountries(String fileName) {
             cumulativeDistribution = new Float[temporalCumulative.size()];
             cumulativeDistribution = temporalCumulative.toArray(cumulativeDistribution);
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 
@@ -372,7 +372,7 @@ private void readContinents(String fileName) {
             }
             dictionary.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/PopularPlacesDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/PopularPlacesDictionary.java
@@ -107,7 +107,7 @@ private void load(String fileName) {
             }
             dicPopularPlace.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/TagDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/TagDictionary.java
@@ -227,7 +227,7 @@ private void load(String tagsFileName, String popularTagByCountryFileName, Strin
 
             dictionary.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/TagMatrix.java b/src/main/java/ldbc/snb/datagen/dictionary/TagMatrix.java
@@ -95,7 +95,7 @@ private void load(String tagMatrixFileName) {
             }
             dictionary.close();
         } catch (Exception e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/TagTextDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/TagTextDictionary.java
@@ -83,7 +83,7 @@ private void load(String fileName) {
             }
             dictionary.close();
         } catch (Exception e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/UniversityDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/UniversityDictionary.java
@@ -135,7 +135,7 @@ private void load(String fileName) {
             }
             dicAllInstitutes.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/dictionary/UserAgentDictionary.java b/src/main/java/ldbc/snb/datagen/dictionary/UserAgentDictionary.java
@@ -77,7 +77,7 @@ private void load(String fileName) {
             }
             agentFile.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/generator/distribution/EmpiricalDistribution.java b/src/main/java/ldbc/snb/datagen/generator/distribution/EmpiricalDistribution.java
@@ -64,10 +64,9 @@ public List<Bucket> getBuckets(Configuration conf) {
             reader.close();
             return Bucket.bucketizeHistogram(histogram, 1000);
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         } catch (Exception e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
-        return null;
     }
 }
diff --git a/src/main/java/ldbc/snb/datagen/generator/distribution/FacebookDegreeDistribution.java b/src/main/java/ldbc/snb/datagen/generator/distribution/FacebookDegreeDistribution.java
@@ -83,9 +83,9 @@ public void loadFBBuckets() {
             }
             fbDataReader.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         } catch (Exception e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/generator/generators/PersonActivityGenerator.java b/src/main/java/ldbc/snb/datagen/generator/generators/PersonActivityGenerator.java
@@ -98,7 +98,6 @@ private void generateActivity(Person person, List<Person> block) throws Assertio
         } catch (AssertionError e) {
             System.out.println("Assertion error when generating activity!");
             System.out.println(e.getMessage());
-            e.printStackTrace();
             throw e;
         }
     }

diff --git a/src/main/java/ldbc/snb/datagen/generator/generators/knowsgenerators/BterKnowsGenerator.java b/src/main/java/ldbc/snb/datagen/generator/generators/knowsgenerators/BterKnowsGenerator.java
@@ -183,7 +183,7 @@ public void generateKnows(List<Person> persons, int seed, List<Float> percentage
             }
             reader.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
 
         p[0] = 0.0;

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/generator/HadoopKnowsGenerator.java b/src/main/java/ldbc/snb/datagen/hadoop/generator/HadoopKnowsGenerator.java
@@ -105,7 +105,7 @@ protected void setup(Context context) {
                                                                        .newInstance();
             } catch (Exception e) {
                 System.out.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/generator/HadoopPersonActivityGenerator.java b/src/main/java/ldbc/snb/datagen/hadoop/generator/HadoopPersonActivityGenerator.java
@@ -107,7 +107,7 @@ protected void setup(Context context) {
 
             } catch (Exception e) {
                 System.err.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 
@@ -148,7 +148,6 @@ protected void cleanup(Context context) {
                 personFactors_.close();
                 friends_.close();
             } catch (IOException e) {
-                e.printStackTrace();
                 throw new RuntimeException(e);
             }
             dynamicActivitySerializer_.close();
@@ -217,7 +216,7 @@ public void run(String inputFileName) throws AssertionError, Exception {
             fs.delete(new Path(conf.get("ldbc.snb.datagen.serializer.hadoopDir") + "/aux"), true);
         } catch (IOException e) {
             System.err.println(e.getMessage());
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/generator/HadoopPersonGenerator.java b/src/main/java/ldbc/snb/datagen/hadoop/generator/HadoopPersonGenerator.java
@@ -77,7 +77,7 @@ public void map(LongWritable key, Text value, Context context)
             } catch (Exception e) {
                 System.err.println("Error when setting key setter");
                 System.err.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
 
             int threadId = Integer.parseInt(value.toString());
@@ -135,7 +135,7 @@ private static void writeToOutputFile(String filename, int numMaps, Configuratio
                 output.write((new String(i + "\n").getBytes()));
             output.close();
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/miscjob/HadoopFileRanker.java b/src/main/java/ldbc/snb/datagen/hadoop/miscjob/HadoopFileRanker.java
@@ -90,13 +90,13 @@ public void setup(Context context) {
                 keySetter = (HadoopFileKeyChanger.KeySetter) Class.forName(className).newInstance();
             } catch (ClassNotFoundException e) {
                 System.out.print(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             } catch (IllegalAccessException e) {
                 System.out.print(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             } catch (InstantiationException e) {
                 System.out.print(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 
@@ -194,7 +194,7 @@ public void setup(Context context) {
                 }
             } catch (IOException e) {
                 System.err.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
 
             counters[0] = 0;

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/miscjob/HadoopMergeFriendshipFiles.java b/src/main/java/ldbc/snb/datagen/hadoop/miscjob/HadoopMergeFriendshipFiles.java
@@ -75,7 +75,7 @@ protected void setup(Context context) {
                                                                        .newInstance();
             } catch (Exception e) {
                 System.out.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/miscjob/keychanger/HadoopFileKeyChanger.java b/src/main/java/ldbc/snb/datagen/hadoop/miscjob/keychanger/HadoopFileKeyChanger.java
@@ -77,13 +77,13 @@ public void setup(Context context) {
                 keySetter = (HadoopFileKeyChanger.KeySetter) Class.forName(className).newInstance();
             } catch (ClassNotFoundException e) {
                 System.out.print(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             } catch (IllegalAccessException e) {
                 System.out.print(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             } catch (InstantiationException e) {
                 System.out.print(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopPersonSerializer.java b/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopPersonSerializer.java
@@ -88,7 +88,7 @@ protected void setup(Context context) {
                 }
             } catch (Exception e) {
                 System.err.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopPersonSortAndSerializer.java b/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopPersonSortAndSerializer.java
@@ -94,7 +94,7 @@ protected void setup(Context context) {
                 }
             } catch (Exception e) {
                 System.err.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopStaticSerializer.java b/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopStaticSerializer.java
@@ -75,7 +75,7 @@ public void run() throws Exception {
             }
         } catch (Exception e) {
             System.err.println(e.getMessage());
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
 
         exportPlaces();

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopUpdateStreamSerializer.java b/src/main/java/ldbc/snb/datagen/hadoop/serializer/HadoopUpdateStreamSerializer.java
@@ -77,7 +77,7 @@ protected void setup(Context context) {
                 }
             } catch (Exception e) {
                 System.err.println(e.getMessage());
-                e.printStackTrace();
+                throw new RuntimeException(e);
             }
         }
 

diff --git a/src/main/java/ldbc/snb/datagen/hadoop/writer/HdfsWriter.java b/src/main/java/ldbc/snb/datagen/hadoop/writer/HdfsWriter.java
@@ -81,7 +81,7 @@ public void write(String entry) {
             currentPartition = ++currentPartition % numPartitions;
         } catch (IOException e) {
             System.out.println("Cannot write to output file ");
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 
@@ -92,7 +92,7 @@ public void writeAllPartitions(String entry) {
             }
         } catch (IOException e) {
             System.out.println("Cannot write to output file ");
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/util/ConfigParser.java b/src/main/java/ldbc/snb/datagen/util/ConfigParser.java
@@ -162,8 +162,7 @@ public static Configuration readConfig(Configuration conf, InputStream paramStre
             }
         } catch (Exception e) {
             System.err.println(e.getMessage());
-            e.printStackTrace();
-            System.exit(-1);
+            throw new RuntimeException(e);
         }
         return conf;
     }

diff --git a/src/main/java/ldbc/snb/datagen/util/Distribution.java b/src/main/java/ldbc/snb/datagen/util/Distribution.java
@@ -70,7 +70,7 @@ public void initialize() {
                 ++index;
             }
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }
 

diff --git a/src/main/java/ldbc/snb/datagen/util/DistributionKey.java b/src/main/java/ldbc/snb/datagen/util/DistributionKey.java
@@ -94,7 +94,7 @@ public void initialize() {
             }
 
         } catch (IOException e) {
-            e.printStackTrace();
+            throw new RuntimeException(e);
         }
     }