Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the remove from favourites issue #84

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

AdityaGahukar
Copy link
Contributor

Fixes #83

Summary

This PR addresses the following issues and implements several key features for the Giphy Explorer project:

  • Bug Fix: Fixed the modal close button functionality, which was previously not working. Now, users can properly close the "Share GIF" modal using the cross button.
  • Feature Addition: Added the ability to upload GIFs directly through the file upload option, and ensured only GIF files are accepted.

Changes Made

  1. Modal Close Button:

    • Fixed the close button functionality by adding an event listener that removes the modal from view when the button is clicked.
  2. File Upload Handling:

    • Implemented an event listener that allows users to upload GIF files.
    • Restricted the file type to only accept .gif images.
  3. Favorites Management:

    • Added functionality to remove GIFs from favorites, both in the modal and the main list.

How to Test

  1. GIF Upload:

    • Click on the "Upload GIF" button and choose a .gif file from your system.
    • Ensure that non-GIF files are rejected.
  2. Sharing and Removing GIFs:

    • Click on a GIF to open the modal.
    • Test the share buttons for Facebook, Twitter, and Pinterest.
    • Test the "Copy Link" button and ensure the URL is copied.
    • Click on "Remove" to remove the GIF from your favorites list.
  3. Close Button:

    • Open the modal by clicking on a GIF and close it using the cross button (top-right corner).

Let me know if you'd like to see any further changes, or if you encounter any issues while testing this PR.

@lcrojano lcrojano added good first issue Good for newcomers hacktoberfest-accepted hacktoberfest-accepted hacktoberfest labels Oct 24, 2024
@lcrojano lcrojano merged commit 4ef603e into lcrojano:main Oct 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] GIFs are not being removed from favorites after reloading the page
2 participants