Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sad fix #35

Merged
merged 11 commits into from
May 2, 2024
Merged

Sad fix #35

merged 11 commits into from
May 2, 2024

Conversation

YAY-C
Copy link
Contributor

@YAY-C YAY-C commented May 1, 2024

No description provided.

@YAY-C YAY-C linked an issue May 1, 2024 that may be closed by this pull request
Fix SAD-guess representation for open-shell systems #32
Closed
@YAY-C YAY-C requested a review from briling May 1, 2024 15:13
briling
briling requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@briling briling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test data to the test and maybe merge it with the spahm-a test?

@YAY-C YAY-C requested a review from briling May 1, 2024 19:39
@briling briling merged commit 8cd0976 into master May 2, 2024
2 checks passed
@briling briling deleted the sad_fix branch May 2, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briling briling Awaiting requested review from briling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SAD-guess representation for open-shell systems
2 participants
@YAY-C @briling