Reposts with deletions/edits V3 #3706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2022
moodyjon
force-pushed
the
stringmap_extensions
branch
from
75f83ef
to
323f6fd
Compare
moodyjon
force-pushed
the
stringmap_extensions
branch
from
3962977
to
63fbf39
Compare
detect whether a repost actually contains modifications.
Rework helpers in attrs.py. TEMP: Add ext.Descriptor.
Only the ext.StringMap extension is supported for now.
Remove unpacking logic and checking for StreamExtensionTypeUnresolved. Add option to use int value in extension payload.
Delete lbry/schema/types/... with the exception of wallet.json.
moodyjon
force-pushed
the
stringmap_extensions
branch
from
afd708b
to
4f1d82a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: lbryio/types#49
This based on #3697, but moving away from
protobuf.Any. This allows deleting some code to detect unknown extension types and the code to unpack a message from theAny.I also discovered that there is a well-known type
protobuf.Structwhich is far more advanced than myStringMapbut serves the same purpose. The backbone ofprotobuf.Structis amap<string, Value>just likeStringMap, butprotobuf.Structcan represent any JSON object with numeric fields, bool fields, string fields, list of X fields, object fields, and more. Using this allowed even more simplification.Definition of
google.protobuf.Struct:https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/struct.proto
To see the claim.proto changes go here:
https://github.com/moodyjon/types/commits/repost_modify
Hub changes that would index the extension fields are here: lbryio/hub#113