-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comic-book reader #2484
Comic-book reader #2484
Conversation
I'm not sure if I should be adding this files inside the static folder:
|
There still some work to do on the repo side: https://github.com/btzr-io/Villain |
The viewer should also work on the website, but I'm not sure how to enable it yet 😛 |
This is awesome! We still have to make some changes to handle viewing any non audio/video content on lbry.tv. Why does this need a webworker? |
@seanyesmunt The worker is required by |
@kauffj Do you know if could be any issues with adding this? https://github.com/nika-begiashvili/libarchivejs |
@btzr-io I think this is fine. Can you just add a comment above the static scripts that explains why they are there? |
I only took a quick glance, but I don't see why we couldn't add libarchivejs. It's worth considering: 1) whether archive support should be added to the SDK and 2) how this will work on the web, but neither are blocking considerations. |
@seanyesmunt in this file ? |
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #1377
What is the current behavior?
There is no viewer for comic book archives
What is the new behavior?
A simple viewer for comic book archives (CBR, CBT, CBZ, CB7)