Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2885 fan coil unit controls #3960

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Issue2885 fan coil unit controls #3960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09c6df1
Merge pull request #134 from lbl-srg/issue2885_FanCoilUnitControls
karthikeyad-pnnl May 2, 2024
8062283
Added additional parameter for symmetry between plant and reset reque…
karthikeyad-pnnl May 3, 2024
93a5b3b
Added CDL flags to annotations in main controller and submodules
karthikeyad-pnnl May 3, 2024
44b8796
Changed validation model settings to change window open status
karthikeyad-pnnl Aug 15, 2024
245aaf8
Changed window status to open for one instance
karthikeyad-pnnl Aug 15, 2024
7323a47
Updated unit test results
karthikeyad-pnnl Aug 15, 2024
0bdcaf5
Updated incorrect comment on controller instance
karthikeyad-pnnl Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 26 additions & 28 deletions Buildings/Controls/OBC/ASHRAE/G36/FanCoilUnit/Controller.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,27 @@ block Controller
Dialog(group="System and building parameters"));

parameter Boolean have_winSen=false
"True if the zone has window status sensor";
"True if the zone has window status sensor"
annotation(__cdl(ValueInReference=false));

parameter Boolean have_occSen=false
"True if the zone has occupancy sensor";
"True if the zone has occupancy sensor"
annotation(__cdl(ValueInReference=false));

parameter Real heaDea(
unit="1",
displayUnit="1")=0.05
"Heating loop signal limit above which controller operation changes from deadband mode to heating mode"
annotation (Dialog(
enable=heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.WaterBased
annotation (__cdl(ValueInReference=false),
Dialog(enable=heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.WaterBased
or heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.Electric));

parameter Real cooDea(
unit="1",
displayUnit="1")=0.05
"Cooling loop signal limit above which controller operation changes from deadband mode to cooling mode"
annotation(Dialog(
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased
annotation(__cdl(ValueInReference=false),
Dialog(enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased
or cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.DXCoil));

parameter Buildings.Controls.OBC.CDL.Types.SimpleController controllerTypeCoo=
Expand Down Expand Up @@ -177,7 +179,8 @@ block Controller
unit="1",
displayUnit="1")=0.1
"Deadband mode fan speed"
annotation (Dialog(tab="Supply air setpoints",group="Fan speed"));
annotation (__cdl(ValueInReference=false),
Dialog(tab="Supply air setpoints",group="Fan speed"));

parameter Real uHeaFan_max(unit="1")=1
"Maximum heating loop signal at which fan speed is modified"
Expand All @@ -193,7 +196,8 @@ block Controller

parameter Real heaSpe_min(unit="1")=0.1
"Minimum fan speed for heating"
annotation (Dialog(tab="Supply air setpoints",group="Fan speed - Heating",
annotation (__cdl(ValueInReference=false),
Dialog(tab="Supply air setpoints",group="Fan speed - Heating",
enable=heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.WaterBased
or heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.Electric));

Expand All @@ -211,7 +215,8 @@ block Controller

parameter Real cooSpe_min(unit="1")=0.1
"Minimum fan speed for cooling"
annotation (Dialog(tab="Supply air setpoints",group="Fan speed - Cooling",
annotation (__cdl(ValueInReference=false),
Dialog(tab="Supply air setpoints",group="Fan speed - Cooling",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased
or cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.DXCoil));

Expand Down Expand Up @@ -307,49 +312,49 @@ block Controller
unit="1",
displayUnit="1")=0.1
"Valve position limit below which zero chilled water plant requests are sent when one request was previously being sent"
annotation(Dialog(tab="Request limits", group="Chilled water requests",
annotation(Dialog(tab="Request limits", group="Chilled water plant requests",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased));

parameter Real chiWatResReqLim0(
unit="1",
displayUnit="1")=0.85
"Valve position limit below which zero chilled water reset requests are sent when one request was previously being sent"
annotation(Dialog(tab="Request limits", group="Chilled water requests",
annotation(Dialog(tab="Request limits", group="Chilled water temperature reset requests",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased));

parameter Real chiWatPlaReqLim1(
unit="1",
displayUnit="1")=0.95
"Valve position limit above which one chilled water plant request is sent"
annotation(Dialog(tab="Request limits", group="Chilled water requests",
annotation(Dialog(tab="Request limits", group="Chilled water plant requests",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased));

parameter Real chiWatResReqLim2(
unit="K",
displayUnit="K")=2.78
"Temperature difference limit between setpoint and supply air temperature above which two chilled water reset requests are sent"
annotation(Dialog(tab="Request limits", group="Chilled water requests",
annotation(Dialog(tab="Request limits", group="Chilled water temperature reset requests",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased));

parameter Real chiWatResReqTimLim2(
unit="s",
displayUnit="s")=300
"Time period for which chiWatResReqLim2 has to be exceeded before two chilled water reset requests are sent"
annotation(Dialog(tab="Request limits", group="Chilled water requests",
annotation(Dialog(tab="Request limits", group="Chilled water temperature reset requests",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased));

parameter Real chiWatResReqLim3(
unit="K",
displayUnit="K")=5.56
"Temperature difference limit between setpoint and supply air temperature above which three chilled water reset requests are sent"
annotation(Dialog(tab="Request limits", group="Chilled water requests",
annotation(Dialog(tab="Request limits", group="Chilled water temperature reset requests",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased));

parameter Real chiWatResReqTimLim3(
unit="s",
displayUnit="s")=300
"Time period for which chiWatResReqLim3 has to be exceeded before three chilled water reset requests are sent"
annotation(Dialog(tab="Request limits", group="Chilled water requests",
annotation(Dialog(tab="Request limits", group="Chilled water temperature reset requests",
enable=cooCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased));

parameter Real hotWatPlaReqLim0(
Expand Down Expand Up @@ -405,19 +410,19 @@ block Controller
unit="1",
displayUnit="1")=-0.1
"Lower limit of the hysteresis for checking temperature difference"
annotation (Dialog(tab="Advanced"));
annotation (__cdl(ValueInReference=false), Dialog(tab="Advanced"));

parameter Real uHigh(
unit="1",
displayUnit="1")=0.1
"Higher limit of the hysteresis for checking temperature difference"
annotation (Dialog(tab="Advanced"));
annotation (__cdl(ValueInReference=false), Dialog(tab="Advanced"));

parameter Real deaHysLim(
unit="1",
displayUnit="1")=0.01
"Hysteresis limits for cooling and heating loop signals for deadband mode transitions"
annotation (Dialog(tab="Advanced"));
annotation (__cdl(ValueInReference=false), Dialog(tab="Advanced"));

parameter Real preWarCooTim(
unit="s",
Expand All @@ -429,19 +434,13 @@ block Controller
unit="1",
displayUnit="1")=0.1
"Hysteresis for checking temperature difference"
annotation(Dialog(tab="Advanced"));

parameter Real posHys(
unit="1",
displayUnit="1")=0.05
"Hysteresis for checking valve position difference"
annotation(Dialog(tab="Advanced"));
annotation(__cdl(ValueInReference=false), Dialog(tab="Advanced"));

parameter Real dFanSpe(
unit="1",
displayUnit="1")=0.05
"Fan speed hysteresis difference"
annotation(Dialog(tab="Advanced"));
annotation(__cdl(ValueInReference=false), Dialog(tab="Advanced"));

Buildings.Controls.OBC.CDL.Interfaces.BooleanInput u1Occ
"Current occupancy period, true if it is in occupant period"
Expand Down Expand Up @@ -717,7 +716,6 @@ protected
final hotWatResReqLim3=hotWatResReqLim3,
final hotWatResReqTimLim3=hotWatResReqTimLim3,
final Thys=Thys,
final posHys=posHys,
final dFanSpe=dFanSpe) if cooCoi == Buildings.Controls.OBC.ASHRAE.G36.Types.CoolingCoil.WaterBased
or heaCoi == Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.WaterBased
"Block for generating chilled water requests and hot water requests for their respective plants"
Expand Down
34 changes: 22 additions & 12 deletions Buildings/Controls/OBC/ASHRAE/G36/FanCoilUnit/Subsequences/FanSpeed.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,25 @@ block FanSpeed
"Fan speed setpoint subsequence"

parameter Boolean have_cooCoi
"True if the unit has a cooling coil";
"True if the unit has a cooling coil"
annotation(__cdl(ValueInReference=false));

parameter Boolean have_heaCoi
"True if the unit has a heating coil";
"True if the unit has a heating coil"
annotation(__cdl(ValueInReference=false));

parameter Real deaSpe(
final unit="1",
displayUnit="1") = 0.1
"Deadband mode fan speed"
annotation(Dialog(group="Deadband"));
annotation(__cdl(ValueInReference=false), Dialog(group="Deadband"));

parameter Real heaSpe_min(
final unit="1",
displayUnit="1") = 0.1
"Minimum heating mode fan speed"
annotation(Dialog(group="Heating loop", enable = have_heaCoi));
annotation(__cdl(ValueInReference=false),
Dialog(group="Heating loop", enable = have_heaCoi));

parameter Real uHea_min(
final unit="1",
Expand All @@ -30,7 +33,8 @@ block FanSpeed
final unit="1",
displayUnit="1") = 0.6
"Maximum heating mode fan speed"
annotation(Dialog(group="Heating loop", enable = have_heaCoi));
annotation(__cdl(ValueInReference=false),
Dialog(group="Heating loop", enable = have_heaCoi));

parameter Real uHea_max(
final unit="1",
Expand All @@ -42,7 +46,8 @@ block FanSpeed
final unit="1",
displayUnit="1") = 0.2
"Minimum cooling mode fan speed"
annotation(Dialog(group="Cooling loop", enable = have_cooCoi));
annotation(__cdl(ValueInReference=false),
Dialog(group="Cooling loop", enable = have_cooCoi));

parameter Real uCoo_min(
final unit="1",
Expand All @@ -54,7 +59,8 @@ block FanSpeed
final unit="1",
displayUnit="1") = 1
"Maximum cooling mode fan speed"
annotation(Dialog(group="Cooling loop", enable = have_cooCoi));
annotation(__cdl(ValueInReference=false),
Dialog(group="Cooling loop", enable = have_cooCoi));

parameter Real uCoo_max(
final unit="1",
Expand All @@ -65,20 +71,24 @@ block FanSpeed
parameter Real heaDea(
final unit="1",
displayUnit="1") = 0.05
"Heating loop signal limit above which fan operation changes from deadband mode to heating mode"
annotation(Dialog(group="Deadband", enable = have_heaCoi));
"Heating loop signal limit above which fan operation changes from deadband
mode to heating mode"
annotation(__cdl(ValueInReference=false),
Dialog(group="Deadband", enable = have_heaCoi));

parameter Real cooDea(
final unit="1",
displayUnit="1") = 0.05
"Cooling loop signal limit above which fan operation changes from deadband mode to cooling mode"
annotation(Dialog(group="Deadband", enable = have_cooCoi));
"Cooling loop signal limit above which fan operation changes from deadband
mode to cooling mode"
annotation(__cdl(ValueInReference=false),
Dialog(group="Deadband", enable = have_cooCoi));

parameter Real deaHysLim(
final unit="1",
displayUnit="1") = 0.01
"Hysteresis limits for deadband mode transitions"
annotation(Dialog(tab="Advanced"));
annotation(__cdl(ValueInReference=false), Dialog(tab="Advanced"));

Buildings.Controls.OBC.CDL.Interfaces.BooleanInput u1FanPro
"Fan proven on signal"
Expand Down
Loading