Ibpsa1880 mover efficiency fix and validation rework #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df5c22b.
sed -i 's/Added nominal curve specification to suppress warning./Specified <code>nominalValuesDefineDefaultPressureCurve=true<\/code>\nin the mover component to suppress a warning./g' $(find . -iname '*.mo')
This was referenced May 28, 2024
|
CI translation fail https://app.travis-ci.com/github/lbl-srg/modelica-buildings/jobs/622317035 reported to OpenModelica in OpenModelica/OpenModelica#12484. |
|
This PR for |
mwetter
approved these changes
Jun 26, 2024
|
This includes the changes from #3842 and hence from the latest IBPSA master. |
This reverts commit 7df3c6b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges changes in ibpsa/modelica-ibpsa#1881 adds entries in the conversion script the release notes as appropriate for the buildings library.
This PR is merged with #3830 and is therefore marked as draft until #3830 is merged to master.