Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue3819 mover model warnings #3830

Closed
wants to merge 60 commits into from
Closed
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
df5c22b
temporarily elevated assert warnings to errors
hcasperfu May 8, 2024
14d7768
default efficiency methods now depend on pressure curve availability
hcasperfu May 9, 2024
650d1f6
added specification Examples.MoverParameter
hcasperfu May 9, 2024
e3a8286
added nominal curve specification Validation.Pump_y_stratos
hcasperfu May 9, 2024
1ea4e1d
added nominal curve specification Validation.FlowControlled_dp and _m…
hcasperfu May 9, 2024
d558f7a
added default curve specification Validation.PumpCurveDerivatives
hcasperfu May 9, 2024
536750a
added default curve specification Validation.FlowControlled_dpSystem
hcasperfu May 9, 2024
be6a235
added default curve specification Examples.Tutorial.Boiler
hcasperfu May 9, 2024
b7e1dbf
added default curve specifications Examples.Tutorial.SpaceCooling
hcasperfu May 9, 2024
a6a801d
added default curve specification Examples..ChillerSetPointControl
hcasperfu May 9, 2024
2e18189
added default curve specification BoilerPolynomialClosedLoop
hcasperfu May 9, 2024
537fd73
added default curve specification Fluid.FMI, removed redundant
hcasperfu May 9, 2024
94e7a96
added default curve specification RectangularBorefield
hcasperfu May 9, 2024
e8189e1
Revert "temporarily elevated assert warnings to errors"
hcasperfu May 9, 2024
f7bbce1
updated stats DHC
hcasperfu May 9, 2024
ba47078
updated release notes
hcasperfu May 10, 2024
afcb952
improved code indentation
hcasperfu May 10, 2024
32fa963
updated release notes
hcasperfu May 10, 2024
24a2d3f
rewrote change log to make it clearer
hcasperfu May 10, 2024
d7fe6b6
Merges development branch 12.0.0 to the master (#3826)
mwetter May 15, 2024
ac668a7
merged master
hcasperfu May 16, 2024
88cafbc
Moved data file to Resources folder (#3833)
mwetter May 16, 2024
69bc4c7
Merged updated heat pump examples from IBPSA master (#3836)
mwetter May 18, 2024
1771438
Merged solar collectors from IBPSA (#3838)
mwetter May 18, 2024
318bd78
Merge IBPSA master (#3839)
mwetter May 20, 2024
9411156
Removed parameter dynFil in borefield models (#3835)
mwetter May 21, 2024
11a1df9
merged master to resolve conflicts
hcasperfu May 28, 2024
bfc863c
Revert "merged master to resolve conflicts"
hcasperfu May 28, 2024
99d3c63
Revert "merged master"
hcasperfu May 28, 2024
70b190f
merged maint_11.x
hcasperfu May 28, 2024
50dc129
temporarily elevated assert warnings to errors
hcasperfu May 8, 2024
6e0c799
default efficiency methods now depend on pressure curve availability
hcasperfu May 9, 2024
352dd89
added specification Examples.MoverParameter
hcasperfu May 9, 2024
622caf9
added nominal curve specification Validation.Pump_y_stratos
hcasperfu May 9, 2024
7756d6b
added nominal curve specification Validation.FlowControlled_dp and _m…
hcasperfu May 9, 2024
ea99d7e
added default curve specification Validation.PumpCurveDerivatives
hcasperfu May 9, 2024
4b4566e
added default curve specification Validation.FlowControlled_dpSystem
hcasperfu May 9, 2024
4f9e5fd
added default curve specification Examples.Tutorial.Boiler
hcasperfu May 9, 2024
c329f2e
added default curve specifications Examples.Tutorial.SpaceCooling
hcasperfu May 9, 2024
e8fb3ee
added default curve specification Examples..ChillerSetPointControl
hcasperfu May 9, 2024
a805ae3
added default curve specification BoilerPolynomialClosedLoop
hcasperfu May 9, 2024
1d18e41
added default curve specification Fluid.FMI, removed redundant
hcasperfu May 9, 2024
27dcbe2
added default curve specification RectangularBorefield
hcasperfu May 9, 2024
d121a29
Revert "temporarily elevated assert warnings to errors"
hcasperfu May 9, 2024
4576151
updated stats DHC
hcasperfu May 9, 2024
4774a33
updated release notes
hcasperfu May 10, 2024
49f73ee
improved code indentation
hcasperfu May 10, 2024
b99ac83
updated release notes
hcasperfu May 10, 2024
ccca415
rewrote change log to make it clearer
hcasperfu May 10, 2024
216fa8f
Merges development branch 12.0.0 to the master (#3826)
mwetter May 15, 2024
c001f95
Moved data file to Resources folder (#3833)
mwetter May 16, 2024
b5db203
Merged updated heat pump examples from IBPSA master (#3836)
mwetter May 18, 2024
c1f5183
Merged solar collectors from IBPSA (#3838)
mwetter May 18, 2024
19a8804
Merge IBPSA master (#3839)
mwetter May 20, 2024
8ba43a9
Removed parameter dynFil in borefield models (#3835)
mwetter May 21, 2024
9370b49
Revert "merged master to resolve conflicts"
hcasperfu May 28, 2024
4d46845
Revert "merged master"
hcasperfu May 28, 2024
ae0ae23
checkout to old commit to remove irrelevant changes
hcasperfu May 28, 2024
9afa232
removed old release notes
hcasperfu May 28, 2024
243c3a0
Merge branch 'issue3819_moverModelWarnings' of https://github.com/lbl…
hcasperfu May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions Buildings/.copiedFiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1883,6 +1883,78 @@ Buildings/Fluid/Sensors/Velocity.mo
Buildings/Fluid/Sensors/VolumeFlowRate.mo
Buildings/Fluid/Sensors/package.mo
Buildings/Fluid/Sensors/package.order
Buildings/Fluid/SolarCollectors/ASHRAE93.mo
Buildings/Fluid/SolarCollectors/BaseClasses/ASHRAEHeatLoss.mo
Buildings/Fluid/SolarCollectors/BaseClasses/ASHRAESolarGain.mo
Buildings/Fluid/SolarCollectors/BaseClasses/EN12975HeatLoss.mo
Buildings/Fluid/SolarCollectors/BaseClasses/EN12975SolarGain.mo
Buildings/Fluid/SolarCollectors/BaseClasses/Examples/ASHRAEHeatLoss.mo
Buildings/Fluid/SolarCollectors/BaseClasses/Examples/ASHRAESolarGain.mo
Buildings/Fluid/SolarCollectors/BaseClasses/Examples/EN12975HeatLoss.mo
Buildings/Fluid/SolarCollectors/BaseClasses/Examples/EN12975SolarGain.mo
Buildings/Fluid/SolarCollectors/BaseClasses/Examples/package.mo
Buildings/Fluid/SolarCollectors/BaseClasses/Examples/package.order
Buildings/Fluid/SolarCollectors/BaseClasses/IAM.mo
Buildings/Fluid/SolarCollectors/BaseClasses/PartialHeatLoss.mo
Buildings/Fluid/SolarCollectors/BaseClasses/PartialParameters.mo
Buildings/Fluid/SolarCollectors/BaseClasses/PartialSolarCollector.mo
Buildings/Fluid/SolarCollectors/BaseClasses/package.mo
Buildings/Fluid/SolarCollectors/BaseClasses/package.order
Buildings/Fluid/SolarCollectors/Controls/BaseClasses/Examples/GCritCalc.mo
Buildings/Fluid/SolarCollectors/Controls/BaseClasses/Examples/package.mo
Buildings/Fluid/SolarCollectors/Controls/BaseClasses/Examples/package.order
Buildings/Fluid/SolarCollectors/Controls/BaseClasses/GCritCalc.mo
Buildings/Fluid/SolarCollectors/Controls/BaseClasses/package.mo
Buildings/Fluid/SolarCollectors/Controls/BaseClasses/package.order
Buildings/Fluid/SolarCollectors/Controls/CollectorPump.mo
Buildings/Fluid/SolarCollectors/Controls/Examples/SolarPumpController.mo
Buildings/Fluid/SolarCollectors/Controls/Examples/package.mo
Buildings/Fluid/SolarCollectors/Controls/Examples/package.order
Buildings/Fluid/SolarCollectors/Controls/package.mo
Buildings/Fluid/SolarCollectors/Controls/package.order
Buildings/Fluid/SolarCollectors/Data/BaseClasses/Generic.mo
Buildings/Fluid/SolarCollectors/Data/BaseClasses/package.mo
Buildings/Fluid/SolarCollectors/Data/BaseClasses/package.order
Buildings/Fluid/SolarCollectors/Data/BaseClasses/validateAngles.mo
Buildings/Fluid/SolarCollectors/Data/GenericASHRAE93.mo
Buildings/Fluid/SolarCollectors/Data/GenericEN12975.mo
Buildings/Fluid/SolarCollectors/Data/GlazedFlatPlate/FP_GuangdongFSPTY95.mo
Buildings/Fluid/SolarCollectors/Data/GlazedFlatPlate/FP_SolahartKf.mo
Buildings/Fluid/SolarCollectors/Data/GlazedFlatPlate/FP_TRNSYSValidation.mo
Buildings/Fluid/SolarCollectors/Data/GlazedFlatPlate/FP_ThermaLiteHS20.mo
Buildings/Fluid/SolarCollectors/Data/GlazedFlatPlate/FP_VerificationModel.mo
Buildings/Fluid/SolarCollectors/Data/GlazedFlatPlate/package.mo
Buildings/Fluid/SolarCollectors/Data/GlazedFlatPlate/package.order
Buildings/Fluid/SolarCollectors/Data/Tubular/T_AMKCollectraAGOWR20.mo
Buildings/Fluid/SolarCollectors/Data/Tubular/T_JiaxingDiyiC0130.mo
Buildings/Fluid/SolarCollectors/Data/Tubular/package.mo
Buildings/Fluid/SolarCollectors/Data/Tubular/package.order
Buildings/Fluid/SolarCollectors/Data/package.mo
Buildings/Fluid/SolarCollectors/Data/package.order
Buildings/Fluid/SolarCollectors/EN12975.mo
Buildings/Fluid/SolarCollectors/Examples/FlatPlate.mo
Buildings/Fluid/SolarCollectors/Examples/FlatPlateShaCoeTrue.mo
Buildings/Fluid/SolarCollectors/Examples/FlatPlateTotalArea.mo
Buildings/Fluid/SolarCollectors/Examples/FlatPlateWithTank.mo
Buildings/Fluid/SolarCollectors/Examples/Tubular.mo
Buildings/Fluid/SolarCollectors/Examples/package.mo
Buildings/Fluid/SolarCollectors/Examples/package.order
Buildings/Fluid/SolarCollectors/Types/HeatCapacity.mo
Buildings/Fluid/SolarCollectors/Types/NumberSelection.mo
Buildings/Fluid/SolarCollectors/Types/SystemConfiguration.mo
Buildings/Fluid/SolarCollectors/Types/package.mo
Buildings/Fluid/SolarCollectors/Types/package.order
Buildings/Fluid/SolarCollectors/UsersGuide.mo
Buildings/Fluid/SolarCollectors/Validation/EN12975NPanels.mo
Buildings/Fluid/SolarCollectors/Validation/EN12975_Array.mo
Buildings/Fluid/SolarCollectors/Validation/EN12975_Series.mo
Buildings/Fluid/SolarCollectors/Validation/ExtremeAmbientConditions.mo
Buildings/Fluid/SolarCollectors/Validation/FlatPlate.mo
Buildings/Fluid/SolarCollectors/Validation/FlatPlateNPanels.mo
Buildings/Fluid/SolarCollectors/Validation/package.mo
Buildings/Fluid/SolarCollectors/Validation/package.order
Buildings/Fluid/SolarCollectors/package.mo
Buildings/Fluid/SolarCollectors/package.order
Buildings/Fluid/Sources/BaseClasses/Outside.mo
Buildings/Fluid/Sources/BaseClasses/PartialAirSource.mo
Buildings/Fluid/Sources/BaseClasses/PartialPropertySource.mo
Expand Down Expand Up @@ -2091,6 +2163,7 @@ Buildings/Resources/Data/Fluid/Geothermal/Borefields/HeatTransfer/Validation/Bei
Buildings/Resources/Data/Fluid/Geothermal/Borefields/HeatTransfer/Validation/Cimmino_Bernier_2015_SmallScale.txt
Buildings/Resources/Data/Fluid/HeatPumps/ModularReversible/BaseClasses/LargeScaleWaterToWaterDeclarations.xlsx
Buildings/Resources/Data/Fluid/HeatPumps/Validation/MeasuredHeatPumpData.txt
Buildings/Resources/Data/Fluid/SolarCollectors/Validation/FlatPlate/TRNSYSAnnualData.txt
Buildings/Resources/Data/Utilities/IO/Files/Examples/CSVReader/Data.txt
Buildings/Resources/Data/schedule.txt
Buildings/Resources/Data/scheduleWindows.txt
Expand Down Expand Up @@ -2889,6 +2962,23 @@ Buildings/Resources/Scripts/Dymola/Fluid/Sensors/Examples/TemperatureWetBulb.mos
Buildings/Resources/Scripts/Dymola/Fluid/Sensors/Examples/TraceSubstances.mos
Buildings/Resources/Scripts/Dymola/Fluid/Sensors/Examples/Velocity.mos
Buildings/Resources/Scripts/Dymola/Fluid/Sensors/Examples/VolumeFlowRate.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/BaseClasses/Examples/ASHRAEHeatLoss.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/BaseClasses/Examples/ASHRAESolarGain.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/BaseClasses/Examples/EN12975HeatLoss.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/BaseClasses/Examples/EN12975SolarGain.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Controls/BaseClasses/Examples/GCritCalc.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Controls/Examples/SolarPumpController.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Examples/FlatPlate.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Examples/FlatPlateShaCoeTrue.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Examples/FlatPlateTotalArea.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Examples/FlatPlateWithTank.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Examples/Tubular.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/EN12975NPanels.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/EN12975_Array.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/EN12975_Series.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/ExtremeAmbientConditions.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/FlatPlate.mos
Buildings/Resources/Scripts/Dymola/Fluid/SolarCollectors/Validation/FlatPlateNPanels.mos
Buildings/Resources/Scripts/Dymola/Fluid/Sources/Examples/MassFlowSource_WeatherData.mos
Buildings/Resources/Scripts/Dymola/Fluid/Sources/Examples/Outside.mos
Buildings/Resources/Scripts/Dymola/Fluid/Sources/Examples/Outside_CpData.mos
Expand Down
7 changes: 6 additions & 1 deletion Buildings/DHC/Examples/Combined/BaseClasses/Borefield.mo
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ model Borefield "Geothermal borefield model"
TExt0_start=282.55,
final z0=10,
final dT_dz=0.02,
final dynFil=true,
borFieDat(
filDat=Buildings.Fluid.Geothermal.Borefields.Data.Filling.Bentonite(
kFil=2.0,
Expand Down Expand Up @@ -79,6 +78,12 @@ double U-tube parallel configuration.
</html>", revisions="<html>
<ul>
<li>
May 17, 2024, by Michael Wetter:<br/>
Updated model due to removal of parameter <code>dynFil</code>.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1885\">IBPSA, #1885</a>.
</li>
<li>
January 8, 2024, by David Blum:<br/>
Moved to <code>Buildings.DHC.Examples.Combined.BaseClasses.Borefield</code>.
This is for
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ model ChillerSetPointControl
MediumAir, m_flow_nominal=999)
annotation (Placement(transformation(extent={{0,-70},{20,-50}})));
Buildings.Fluid.Movers.FlowControlled_m_flow pum(
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=1.2*mCHW_flow_nominal,
dp(start=40474),
redeclare package Medium = Medium2,
Expand Down Expand Up @@ -214,6 +215,13 @@ equation
Documentation(revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
August 16, 2019, by Michael Wetter:<br/>
Changed initialization of PI controller for Dymola 2020.
</li>
Expand Down
8 changes: 8 additions & 0 deletions Buildings/Examples/Tutorial/Boiler/System2.mo
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ model System2
Buildings.Fluid.Movers.FlowControlled_m_flow pumRad(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mRad_flow_nominal) "Pump for radiator"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
Expand Down Expand Up @@ -389,6 +390,13 @@ could have been used.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
March 6, 2017, by Michael Wetter:<br/>
Added missing density to computation of air mass flow rate.<br/>
This is for <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/673\">#673</a>.
Expand Down
15 changes: 12 additions & 3 deletions Buildings/Examples/Tutorial/Boiler/System3.mo
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ model System3
Buildings.Fluid.Movers.FlowControlled_m_flow pumRad(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mRad_flow_nominal) "Pump for radiator"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
Expand Down Expand Up @@ -140,9 +141,10 @@ model System3
//----------------------------------------------------------------------------//

Buildings.Fluid.Movers.FlowControlled_m_flow pumBoi(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
rotation=90,
Expand Down Expand Up @@ -576,6 +578,13 @@ this indicates that the model is correct.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
March 6, 2017, by Michael Wetter:<br/>
Added missing density to computation of air mass flow rate.<br/>
This is for <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/673\">#673</a>.
Expand Down
15 changes: 12 additions & 3 deletions Buildings/Examples/Tutorial/Boiler/System4.mo
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ model System4
Buildings.Fluid.Movers.FlowControlled_m_flow pumRad(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mRad_flow_nominal) "Pump for radiator"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
Expand Down Expand Up @@ -140,9 +141,10 @@ model System4
//----------------------------------------------------------------------------//

Buildings.Fluid.Movers.FlowControlled_m_flow pumBoi(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
rotation=90,
Expand Down Expand Up @@ -534,6 +536,13 @@ Buildings.Examples.Tutorial.Boiler.System5</a>.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
March 6, 2017, by Michael Wetter:<br/>
Added missing density to computation of air mass flow rate.<br/>
This is for <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/673\">#673</a>.
Expand Down
15 changes: 12 additions & 3 deletions Buildings/Examples/Tutorial/Boiler/System5.mo
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ model System5
Buildings.Fluid.Movers.FlowControlled_m_flow pumRad(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mRad_flow_nominal) "Pump for radiator"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
Expand Down Expand Up @@ -140,9 +141,10 @@ model System5
//----------------------------------------------------------------------------//

Buildings.Fluid.Movers.FlowControlled_m_flow pumBoi(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
rotation=90,
Expand Down Expand Up @@ -601,6 +603,13 @@ Buildings.Examples.Tutorial.Boiler.System4</a>.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
March 6, 2017, by Michael Wetter:<br/>
Added missing density to computation of air mass flow rate.<br/>
This is for <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/673\">#673</a>.
Expand Down
15 changes: 12 additions & 3 deletions Buildings/Examples/Tutorial/Boiler/System6.mo
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ model System6
Buildings.Fluid.Movers.FlowControlled_m_flow pumRad(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mRad_flow_nominal) "Pump for radiator"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
Expand Down Expand Up @@ -135,9 +136,10 @@ model System6
//----------------------------------------------------------------------------//

Buildings.Fluid.Movers.FlowControlled_m_flow pumBoi(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
rotation=90,
Expand Down Expand Up @@ -589,6 +591,13 @@ maintained at their set point.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
March 6, 2017, by Michael Wetter:<br/>
Added missing density to computation of air mass flow rate.<br/>
This is for <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/673\">#673</a>.
Expand Down
15 changes: 12 additions & 3 deletions Buildings/Examples/Tutorial/Boiler/System7.mo
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ model System7
Buildings.Fluid.Movers.FlowControlled_m_flow pumRad(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mRad_flow_nominal) "Pump for radiator"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
Expand Down Expand Up @@ -135,9 +136,10 @@ model System7
//----------------------------------------------------------------------------//

Buildings.Fluid.Movers.FlowControlled_m_flow pumBoi(
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
redeclare package Medium = MediumW,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mBoi_flow_nominal) "Pump for boiler"
annotation (Placement(transformation(
extent={{-10,-10},{10,10}},
rotation=90,
Expand Down Expand Up @@ -663,6 +665,13 @@ response shown below should be seen.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
February 15, 2022, by Michael Wetter:<br/>
Changed block downstream of <code>greThrTRoo</code> from <code>and</code> to <code>or</code> block.
This ensures that the system is off when the outdoor air or room air is sufficiently warm.
Expand Down
8 changes: 8 additions & 0 deletions Buildings/Examples/Tutorial/SpaceCooling/System2.mo
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ model System2
annotation (Placement(transformation(extent={{20,70},{40,90}})));
Buildings.Fluid.Movers.FlowControlled_m_flow fan(
redeclare package Medium = MediumA,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mA_flow_nominal,
energyDynamics=Modelica.Fluid.Types.Dynamics.SteadyState) "Supply air fan"
annotation (Placement(transformation(extent={{40,-30},{60,-10}})));
Expand Down Expand Up @@ -525,6 +526,13 @@ from the model.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
September 20, 2021 by David Blum:<br/>
Correct supply and return water parameterization.<br/>
Use design conditions for UA parameterization in cooling coil.<br/>
Expand Down
8 changes: 8 additions & 0 deletions Buildings/Examples/Tutorial/SpaceCooling/System3.mo
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ model System3
annotation (Placement(transformation(extent={{20,70},{40,90}})));
Buildings.Fluid.Movers.FlowControlled_m_flow fan(
redeclare package Medium = MediumA,
nominalValuesDefineDefaultPressureCurve=true,
m_flow_nominal=mA_flow_nominal,
energyDynamics=Modelica.Fluid.Types.Dynamics.SteadyState) "Supply air fan"
annotation (Placement(transformation(extent={{40,-30},{60,-10}})));
Expand Down Expand Up @@ -369,6 +370,13 @@ Buildings.Controls.OBC.CDL.Reals.PID</a>.
</html>", revisions="<html>
<ul>
<li>
April 9, 2024, by Hongxiang Fu:<br/>
Specified <code>nominalValuesDefineDefaultPressureCurve=true</code>
in the mover component to suppress a warning.
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3819\">#3819</a>.
</li>
<li>
December 11, 2023, by Jianjun Hu:<br/>
Reimplemented on-off control to avoid using the obsolete <code>OnOffController</code>.
This is for
Expand Down
Loading
Loading